1647292 - The credit card image placeholder is not displayed in the doorhanger when no cards are saved

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Windows 7

Affected Versions:
All- if CC prefs are enabled

Tested on:

• Windows 7&10

Steps to reproduce:

1. Go to a test page with a payment form, such as https://luke-chang.github.io/autofill-demo/basic_cc.html
2. Fill in a generated credit card number and the other required fields and hit submit

Expected:
The Save Credit Card doorhanger is displayed with:
*Credit Card image placeholder on the left side of the masked CC number.

Actual:
The credit card image placeholder is not displayed in the doorhanger

Note:
Not reproducible on Win10 and MacOS. Ubuntu to be tested.

Comment 1

[Timea Cernea [:tbabos][inactive]]

Attachment: Expected Win10

Comment 2

[Adam Roach [:abr]]

Attachment: win7-doorhanger.png

Ignore my previous comment -- I have a reproduction on Win7 and will attempt to debug.

Comment 3

[Adam Roach [:abr]]

Adjusting the title to reflect the underlying issue.

This happens on all platforms if the doorhanger is displayed before any autofill popups are shown. You can reproduce this by removing all cards, restarting the browser, and then running through the STR in Comment 0.

Comment 4

[Adam Roach [:abr]]

Attachment: Bug 1647292: Ensure CSS is loaded before doorhanger might open r?zbraniecki!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03076ceaad17
Ensure CSS is loaded before doorhanger might open r=zbraniecki

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/03076ceaad17

Comment 7

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue with an old Nightly build 79.0a1 (build id: 20200622093309).
Verified - Fixed in latest Nightly 80.0a1 (build id: 20200726214746) following the steps from comment 0, triggering the doorhanger before any autofill popups are shown. Verified on Windows 7 and Windows 10.