Closed Bug 1647292 Opened 3 months ago Closed 2 months ago

The credit card image placeholder is not displayed in the doorhanger when no cards are saved

Categories

(Toolkit :: Form Autofill, defect, P2)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
mozilla80
Tracking Status
firefox77 --- disabled
firefox78 --- disabled
firefox79 --- disabled
firefox80 --- verified

People

(Reporter: tbabos, Assigned: abr)

References

(Blocks 1 open bug)

Details

(Keywords: polish, Whiteboard: [cc-autofill-mvp])

Attachments

(4 files)

Attached image Windows 7

Affected Versions:
All- if CC prefs are enabled

Tested on:

  • Windows 7&10

Steps to reproduce:

  1. Go to a test page with a payment form, such as https://luke-chang.github.io/autofill-demo/basic_cc.html
  2. Fill in a generated credit card number and the other required fields and hit submit

Expected:
The Save Credit Card doorhanger is displayed with:
*Credit Card image placeholder on the left side of the masked CC number.

Actual:
The credit card image placeholder is not displayed in the doorhanger

Note:
Not reproducible on Win10 and MacOS. Ubuntu to be tested.

Attached image Expected Win10
Keywords: polish
Priority: -- → P2
Whiteboard: [ccautofill] → [cc-autofill-mvp]
Flags: needinfo?(jmathies)
Severity: -- → S4
Flags: needinfo?(jmathies)
Assignee: nobody → adam
Status: NEW → ASSIGNED
Attached image win7-doorhanger.png

Ignore my previous comment -- I have a reproduction on Win7 and will attempt to debug.

Flags: needinfo?(jmathies)
Flags: needinfo?(jmathies)

Adjusting the title to reflect the underlying issue.

This happens on all platforms if the doorhanger is displayed before any autofill popups are shown. You can reproduce this by removing all cards, restarting the browser, and then running through the STR in Comment 0.

OS: Windows 7 → All
Summary: [Win7] The credit card image placeholder is not displayed in the doorhanger → The credit card image placeholder is not displayed in the doorhanger when no cards are saved
Pushed by adam@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/03076ceaad17
Ensure CSS is loaded before doorhanger might open r=zbraniecki
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80

Reproduced the initial issue with an old Nightly build 79.0a1 (build id: 20200622093309).
Verified - Fixed in latest Nightly 80.0a1 (build id: 20200726214746) following the steps from comment 0, triggering the doorhanger before any autofill popups are shown. Verified on Windows 7 and Windows 10.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.