Closed Bug 1647310 Opened 4 years ago Closed 3 years ago

Consider not saving the character encoding on cache entries

Categories

(Core :: DOM: Navigation, task, P3)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(1 file)

Considering the one case in nsHTMLDocument::StartDocumentLoad when we store the character encoding on a cache entry, it appears that saving it isn't useful.

We should verify that it isn't useful and remove the reading and the writing of this piece of data as well as the capability to store it.

Severity: -- → N/A
Priority: -- → P3

Storing the charset on cache entries makes the code path uselessly different
when loading from cache relative to uncached loads. Also, for future
telemetry purposes, caching the charset obscures its original source.

Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Blocks: 1648464
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d329cc6b135b
Stop storing charset on cache entries. r=necko-reviewers,dragana
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: