1647424 - [meta] Audit uses of Document::GetTopLevelContentDocument

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Kris Maglione [:kmag]]

+++ This bug was initially created as a clone of Bug #1642433 +++

Similar to uses of nsIDocShellTreeItem, many/most of the callers of these methods will probably do the wrong thing under Fission with remote frames.

Comment 1

[Chris Peterson [:cpeterson]]

All the blocking bugs have been resolved, but kmag says there are still uses of Document::GetTopLevelContentDocument() that look sketchy.

Assigning this bug to him because he said he will audit again.

Tracking audit bugs for Fission M7a. If a call to GetTopLevelContentDocument() needs to be fixed, we want to know sooner (M7a) rather than later (M8).

Comment 2

[Kris Maglione [:kmag]]

I believe the remaining usage in HighPriorityEventPendingForTopLevelDocumentBeforeContentfulPaint is OK, but we should add a comment there explaining why, and either rename the method to something like GetInProcessTopLevelContentDocument or remove it, and inline the remaining usage. Or possibly just replace it with something like FindPresShellForDocument(aDocument)->GetPresContext()->GetRootPresContext().

Comment 3

[Neha Kochar [:neha]]

The audit of existing usage is complete.

Comment 4

[Neha Kochar [:neha]]

The audit is complete and the important usages are fixed. The remaining ones are either not blocking Fission or is already being tracked in MVP. Closing this meta.