Closed Bug 1647430 Opened 3 months ago Closed 2 months ago

Fix use of GetTopLevelContentDocument in Document::SetDocTreeHadAudibleMedia and SetDocTreeHadPlayRevoked

Categories

(Core :: DOM: Core & HTML, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla80
Fission Milestone M6b
Tracking Status
firefox80 --- fixed

People

(Reporter: kmag, Assigned: alwu)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

GetTopLevelContentDocument returns null when the top-level document is in a different process, or there are cross-process interstitials between it and the current document. This means that for these frames, the had audible media flag is never set.

Summary: Fix use of GetTopLevelContentDocument in Document::SetDocTreeHadAudibleMedia → Fix use of GetTopLevelContentDocument in Document::SetDocTreeHadAudibleMedia and SetDocTreeHadPlayRevoked
Severity: -- → S3
Fission Milestone: --- → ?

This will probably affect telemetry.

Fission Milestone: ? → M6c

Nils, could you please confirm if there are other uses of this?

Fission Milestone: M6c → ?
Flags: needinfo?(drno)

:cpearse also for above.

Flags: needinfo?(chris)
Flags: needinfo?(chris)

Alastor could you please have a look if we still need these functions and help fixing them for Fission if needed.

Flags: needinfo?(drno) → needinfo?(alwu)
Assignee: nobody → alwu
Flags: needinfo?(alwu)
See Also: → 1652108
Blocks: 1652108
See Also: 1652108
Attachment #9162889 - Attachment description: Bug 1647430 - part2 : store 'DocTreeHadAudibleMedia' in WindowContext. → Bug 1647430 - part2 : store `DocTreeHadAudibleMedia` in WindowContext.
Attachment #9162890 - Attachment description: Bug 1647430 - part3 : remove 'DocTreeHadPlayRevoked' related variable and method. → Bug 1647430 - part3 : remove `DocTreeHadPlayRevoked` related variable and method.
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3921f59fc880
part1 : add a method to get top level window context. r=nika
https://hg.mozilla.org/integration/autoland/rev/b22521459279
part2 : store `DocTreeHadAudibleMedia` in WindowContext. r=nika
https://hg.mozilla.org/integration/autoland/rev/ec1edb45cb1f
part3 : remove `DocTreeHadPlayRevoked` related variable and method. r=nika
Status: NEW → ASSIGNED
Fission Milestone: ? → M6b
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.