Closed Bug 1647452 Opened 4 years ago Closed 4 years ago

Fix usage of GetFrameElementInternal in nsDocShell::PerformRetargeting and DoLoadURI

Categories

(Core :: DOM: Navigation, defect, P3)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Project Flags:
Fission Milestone M6c

People

(Reporter: kmag, Assigned: smacleod)

References

Details

It's used to provide the frame element as the requesting context in the LoadInfo, but it does different things depending on whether the frame has an in-process or cross-process parent, which is not desirable.

Summary: Fix usage of GetFrameElementInternal in nsDocShell::PerformRetargeting → Fix usage of GetFrameElementInternal in nsDocShell::PerformRetargeting and DoLoadURI
Severity: -- → S3
Priority: -- → P3

The caller in PerformRetargeting appears to not call this method unless we're in the parent process, in which case it should work fine: https://searchfox.org/mozilla-central/rev/82c04b9cad5b98bdf682bd477f2b1e3071b004ad/docshell/base/nsDocShell.cpp#7988-8000

The popup-blocker stuff in DoURILoad probably needs to be fixed, though.

Fission Milestone: --- → M6c
Assignee: nobody → smacleod
Status: NEW → ASSIGNED

None of the remaining cases are fission-incompatible, resolving.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.