Closed Bug 1647455 Opened 10 months ago Closed 10 months ago

[wpt-sync] Sync PR 24295 - Use the correct layout invalidation root in StyleEngine::InvalidateStyleAndLayoutForFontUpdates

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox79 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24295 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24295
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

Use the correct layout invalidation root in StyleEngine::InvalidateStyleAndLayoutForFontUpdates

The function currently uses the LayoutObject of the documentElement as
the layout invalidation root, which is incorrect because there can be
objects not in its subtree. For example, a modal dialog.

This patch fixes it by using the LayoutView, the root of the layout
tree, as the layout invalidation root.

Bug: 1092411
Change-Id: Ic2475fe1fc9fd9029699a410b4f03a9f3812e240
Reviewed-on: https://chromium-review.googlesource.com/2255738
WPT-Export-Revision: b450ae14d828de46b8f99e77d9d14a667cd4d342

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
PASS : 1

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-font-loading/fontface-load-in-modal-dialog.html: ERROR (Chrome: OK, Safari: ERROR)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/891e389f58fb
[wpt PR 24295] - Use the correct layout invalidation root in StyleEngine::InvalidateStyleAndLayoutForFontUpdates, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7471ec0e11c7
[wpt PR 24295] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/891e389f58fb
https://hg.mozilla.org/mozilla-central/rev/7471ec0e11c7

Status: NEW → RESOLVED
Closed: 10 months ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.