Derive AET ecosystemUserId from kB when the user signs in
Categories
(Firefox :: Firefox Accounts, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: rfkelly, Assigned: rfkelly)
References
Details
Attachments
(1 file, 1 obsolete file)
In Bug 1635657 we will have Firefox synthesize a "placeholder" ecosystemUserId
value for Account Ecosystem Telemetry, if one is not available from the FxA server. That's the best we can do for users who are already signed in to Firefox, but for new signins we can do one better and actually derive their long-lived ecosystemUserId
value from their FxA root key kB
, at the same time as we're deriving other key material such as kSync
. We should do so!
Assignee | ||
Comment 1•4 years ago
|
||
(Note that we can only do this on Desktop because Desktop's special login flow gives it access to kB
; on OAuth clients we need to rely on the FxA signin page to to the key derivation for us and return it via the scoped-keys flow).
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
This is getting out of hand; I'm going to spin off the bulk of the refactor work into a separate bug over in Bug 1661407.
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Pushed by rkelly@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f0cbfb83a48e Derive AET ecosystemUserId from kB when the user signs in. r=markh
Comment 6•4 years ago
|
||
Backed out for perma failures.
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=f0cbfb83a48e2cb0c0bb8b2d3a64a8aac506f461&failure_classification_id=2
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317858385&repo=autoland&lineNumber=2429
Backout: https://hg.mozilla.org/integration/autoland/rev/4a7378feb0834656975408bc2e751f9a37f54617
Assignee | ||
Comment 7•4 years ago
|
||
Oof, sorry, now sure how that slipped through my local testing. Fixed and working locally, but I'll also push a try run for completeness before landing again.
Assignee | ||
Comment 8•4 years ago
|
||
(try link, for posterity: https://treeherder.mozilla.org/#/jobs?repo=try&revision=966d487920ad81346f5017dcb7c8e097616d2f09)
Pushed by rkelly@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/842045716617 Derive AET ecosystemUserId from kB when the user signs in. r=markh
Comment 10•4 years ago
|
||
bugherder |
Description
•