1647602 - Fix boolean type in CacheIR

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

CacheIR's GuardToBoolean returns an Int32OperandId. This is fine for some consumers that want an int32, but in other places it's really confusing. I think we should split this in GuardBooleanToInt32 + a proper boolean type for the other cases.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1647602 part 1 - Add a BooleanId type to CacheIR. r?iain!

• Renames the old GuardToBoolean that returned an Int32Id to GuardBooleanToInt32 for now.
• Adds BooleanId and makes various instructions take this instead of Int32Id.
• Fix some TODOs/hacks.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1647602 part 2 - Make GuardToInt32 match other guard instructions. r?iain!

Removes the resultId to match what we do for other types.

We should consider removing the lazy-unboxing scheme to simplify CacheIRCompiler
and change this back for all types, but until then let's at least be consistent.

Depends on D84467

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73aeebb42476
part 1 - Add a BooleanId type to CacheIR. r=iain
https://hg.mozilla.org/integration/autoland/rev/4d570314ac00
part 2 - Make GuardToInt32 match other guard instructions. r=iain

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/73aeebb42476
https://hg.mozilla.org/mozilla-central/rev/4d570314ac00