1647640 - make perftest Python 3.5 compatible

Status: RESOLVED WONTFIX

(Testing :: mozperftest, defect, P1)

Description

[Tarek Ziadé (:tarek)]

We have environments with an older version of python 3, like talos generic workers.

Let's avoid f-strings

[task 2020-06-23T08:23:18.152Z] Traceback (most recent call last):
[task 2020-06-23T08:23:18.152Z]   File "python/mozperftest/mozperftest/runner.py", line 168, in <module>
[task 2020-06-23T08:23:18.152Z]     sys.exit(main())
[task 2020-06-23T08:23:18.152Z]   File "python/mozperftest/mozperftest/runner.py", line 152, in main
[task 2020-06-23T08:23:18.152Z]     from mozperftest import PerftestArgumentParser
[task 2020-06-23T08:23:18.152Z]   File "/home/cltbld/tasks/task_1592896703/builds/worker/checkouts/gecko/python/mozperftest/mozperftest/__init__.py", line 6, in <module>
[task 2020-06-23T08:23:18.152Z]     from mozperftest.argparser import PerftestArgumentParser  # noqa
[task 2020-06-23T08:23:18.152Z]   File "/home/cltbld/tasks/task_1592896703/builds/worker/checkouts/gecko/python/mozperftest/mozperftest/argparser.py", line 19, in <module>
[task 2020-06-23T08:23:18.152Z]     from mozperftest.test import get_layers as test_layers  # noqa
[task 2020-06-23T08:23:18.152Z]   File "/home/cltbld/tasks/task_1592896703/builds/worker/checkouts/gecko/python/mozperftest/mozperftest/test/__init__.py", line 4, in <module>
[task 2020-06-23T08:23:18.152Z]     from mozperftest.test.browsertime import BrowsertimeRunner
[task 2020-06-23T08:23:18.152Z]   File "/home/cltbld/tasks/task_1592896703/builds/worker/checkouts/gecko/python/mozperftest/mozperftest/test/browsertime/__init__.py", line 5, in <module>
[task 2020-06-23T08:23:18.152Z]     from mozperftest.test.browsertime.runner import BrowsertimeRunner  # noqa
[task 2020-06-23T08:23:18.152Z]   File "/home/cltbld/tasks/task_1592896703/builds/worker/checkouts/gecko/python/mozperftest/mozperftest/test/browsertime/runner.py", line 297
[task 2020-06-23T08:23:18.152Z]     result_dir = pathlib.Path(output, f"browsertime-results-{cycle}")
[task 2020-06-23T08:23:18.152Z]                                                                    ^
[task 2020-06-23T08:23:18.152Z] SyntaxError: invalid syntax

Comment 1

[Tarek Ziadé (:tarek)]

Attachment: Bug 1647640 - make perftest Python 3.5 compatible

This patches uses future-fstrings to make them available
with 3.5, and fix the code and tests for 3.5 compat

Comment 2

[Tarek Ziadé (:tarek)]

We're moving talos boxes to python 3.8

See Bug 1647648