164767 - Bad optimisation in ExprParser

Status: NEW

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The ExprParser optimises expressions like "---foo" into "-foo" which is nice.
However it should not optimise "--foo" into "foo" since that will have a
different value if "foo" can't be converted into a number and back without
loosing information. We can fix this either by adding a
ExprParser::createUnaryExpr or by converting "--foo" into "number(foo)"

Comment 1

[Axel Hecht]

Once we fix the parsing of function params, we could actually merge UnaryExpr and
number(). A little bit of footprint.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix. Needs test

Someone filed a dupe of this recently, but I can't seem to find it. Anyhow, I wrote up this. Needs testing, and tests.

Attaching as to not lose it.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.