[wpt-sync] Sync PR 24313 - [LargestContentfulPaint] Fix edge case in experimental LCP
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox80 fixed)
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 24313 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/24313
Details from upstream follow.
Nicolás Peña Moreno <npm@chromium.org> wrote:
[LargestContentfulPaint] Fix edge case in experimental LCP
This bug fixes a problem that may arise when the largest image is
loading and then removed. Before, we'd continue to wait for the paint
time of such image, and hence would only correctly update the
experimental LCP value if we ever painted something at least as large as
that removed image.Bug: 1045640
Change-Id: I356a58215003871cc15e3bee3ed86423ac612934
Reviewed-on: https://chromium-review.googlesource.com/2255498
WPT-Export-Revision: 2e8855e44c5de2bad29961450ce69f5eebcd8428
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 1 subtests
Status Summary
Firefox
OK : 1
FAIL: 1
Chrome
OK : 1
PASS: 1
Safari
OK : 1
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/largest-contentful-paint/image-removed-before-load.html
Largest Contentful Paint: image removed before loaded does not produce entry.: FAIL (Chrome: PASS, Safari: FAIL)
Comment 4•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2e8b3ef7ca9c
https://hg.mozilla.org/mozilla-central/rev/617c1c193ccc
Description
•