1647928 - Further improvements to the attendees dialog

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1647928-attendees-drag-1.diff

This fixes the dragging problem I had, does it fix the one you had?

Comment 2

[Geoff Lankow (:darktrojan)]

Changing this bug to cover a bunch of things because we don't need a new bug for every little thing.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1647928-attendees-grid-header-1.diff

This makes the grid a little bit taller so that the time labels are clearer. I've also tweaked some colours so they're not hard-wired. (I'm still not totally happy with the colours on Mac but there's no simple solution, and it's better than it was in 68.)

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1647928-attendees-grid-header-2.diff

This is more logical.

Comment 5

[Paul Morris [:pmorris]]

Comment on attachment 9158731 [details] [diff] [review]
1647928-attendees-drag-1.diff

Review of attachment 9158731 [details] [diff] [review]:
-----------------------------------------------------------------

This definitely seemed to improve things.  It took longer for the glitches to occur.  They did occur eventually, same as before, with the pink event bar jumping way to the left or the right as soon as you drop it.  I tried playing with the zoom as well.  I was able to get the glitches to appear both with and without zooming first.

Looking closer at what's going on when a glitch happens, the pink bar seems to be getting disconnected from the date and time shown in the dialog fields.  Like it jumps to a day and some number of hours later.  Then when you drag it again it jumps again, but back into sync with the numbers in the fields.

Comment 6

[Paul Morris [:pmorris]]

Comment on attachment 9158769 [details] [diff] [review]
1647928-attendees-grid-header-2.diff

Review of attachment 9158769 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!  Nice improvement for making sense of the time labels in the header.

Comment 7

[Geoff Lankow (:darktrojan)]

Looking closer at what's going on when a glitch happens, the pink bar seems to be getting disconnected from the date and time shown in the dialog fields. Like it jumps to a day and some number of hours later. Then when you drag it again it jumps again, but back into sync with the numbers in the fields.

Weird. But this isn't the most sane drag-and-drop code I've ever written, so hardly a surprise. Hopefully there'll be chances for more work on this dialog.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/376d4a7f56f6
Extend the attendees grid into the header area. r=pmorris DONTBUILD

Comment 9

[Martin Schröder [:mschroeder]]

It seems just one of two patches has been checked in.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/396baf34dbd9
Fix dragging the event bar in the attendees dialog. r=pmorris

Comment 11

[Magnus Melin [:mkmelin]]

Thanks for noticing! Landed now.

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 78.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/dcc756af25ee

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3f371b70ed5e
follow-up - Fix linting failure. rs=linting DONTBUILD

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 79.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/f304dfccd41d

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 78.0:
https://hg.mozilla.org/releases/comm-esr78/rev/305a5dbea041