16480 - Allow overriding of menu "value" in overlay menu items

Status: VERIFIED WONTFIX

(Core :: XUL, defect, P3)

Description

[Charles Manske]

When we use a menu item in an overlay, the menu text ("value" attribute)
is set in the overlay XUL either directly or in an associated observer.
We need to be able to allow different text by setting the value in the "user"
of the overlay item by setting a different "value" string.
E.g.: in the overlay:
<broadcaster id="cmd_1" value="item1" oncommand="foo()">
<menuitem id="menu_1" observes="cmd_1">
User of the overlay:
<menuitem id="menu_1" value="My name">

The text on the menu should be "My name", not "item1", but the command would
still be "foo()"
Note that this currently works when you set an alternate name for a titledbutton
in a toolbar, though hyatt thinks this is actually a bug!

Comment 1

[Peter Trudelle]

reassigning to waterson per hyatt.

Comment 2

[Charles Manske]

I discussed this with Chris and if there's no clear way to know which "setter"
of a value attribute should be used, we can live with repeating the value and
oncommand attributes in cases where we need to have different "value" text,
so we don't reference the overlay item for that case.

Comment 3

[Chris Waterson]

lemme know if this is a problem

Comment 4

[Charles Manske]

No problem. I've figure out ways to do what I need.

Comment 5

[sairuh (rarely reading bugmail)]

mass-verifying WontFix bugs which haven't changed since 2001-12-31.

use the search string "BoletusEdulis" if you want to filter out this msg.