1648001 - Set forced character encoding via docshell

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, task)

Description

[Henri Sivonen (:hsivonen)]

c-c sets the forced charset via nsIContentViewer. Firefox sets in via nsIDocShell. We could have fewer code paths if c-c also set it via nsIDocShell.
https://searchfox.org/comm-central/rev/93db6b3c1403b18025e1ad81466979c5b4cd2772/editor/ui/composer/content/editingOverlay.js#187
https://searchfox.org/comm-central/rev/93db6b3c1403b18025e1ad81466979c5b4cd2772/mailnews/base/src/nsMsgPrintEngine.cpp#471
https://searchfox.org/comm-central/rev/93db6b3c1403b18025e1ad81466979c5b4cd2772/mailnews/compose/src/nsMsgCompose.cpp#1581

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1648001_set_charsetdocshell.patch

editor/ is not really used anymore... but let's change it to avoid confusion

Syntax from bug 1648802 too to avoid merge conflicts later.

Comment 2

[Henri Sivonen (:hsivonen)]

Comment on attachment 9160361 [details] [diff] [review]
bug1648001_set_charsetdocshell.patch

Review of attachment 9160361 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/src/nsMsgPrintEngine.cpp
@@ +464,5 @@
>  
>  void nsMsgPrintEngine::InitializeDisplayCharset() {
>    // libmime always converts to UTF-8 (both HTML and XML)
>    if (mDocShell) {
> +    mDocShell->SetCharset("UTF-8"_ns);

Where is the handling of a `_ns` suffix defined?

Comment 3

[Magnus Melin [:mkmelin]]

This is from bug 1648010, landed earlier today

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9160361 [details] [diff] [review]
bug1648001_set_charsetdocshell.patch

(Resetting review request, bugzilla acting up)

Comment 5

[Henri Sivonen (:hsivonen)]

Comment on attachment 9160361 [details] [diff] [review]
bug1648001_set_charsetdocshell.patch

Review of attachment 9160361 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/15ac0c155ced
Set forced character encoding via docshell instead of via content viewer (content viewer will drop support for that). r=hsivonen DONTBUILD