1648014 - Mark Read by Date stopped working since version 78b2

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Tobias Weibel]

I'm reading blogs through RSS in Thunderbird. I normally read the most interesting articles and then I press "C" to call "Mark Read by Date". Since version 78b2 (maybe b1) the mark as read doesn't work anymore. I still get the dialog to enter the two dates it won't mark the messages anymore. I normally just enter the "to date".

Comment 1

[Tobias Weibel]

Additionally: clicking "Shift + C" (mark all as read) is still working.

Comment 2

[Magnus Melin [:mkmelin]]

Seems to be working for me on trunk. The prefilled to date seems to be yesterdays date, but after I change that to today the messages from today were marked as read.

Comment 3

[Tobias Weibel]

I see the following error in the error console after trying to mark by date:

Uncaught 
Exception
​
columnNumber: 0
​
data: null
​
filename: "chrome://messenger/content/markByDate.js"
​
lineNumber: 121
​
location: XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), filename: Getter, name: Getter, … }
​
message: "Failure arg 0 [nsIMsgFolder.markMessagesRead]"
​
name: "NS_ERROR_FAILURE"
​
result: 2147500037
​
stack: "markInDatabase@chrome://messenger/content/markByDate.js:121:19\nonAccept@chrome://messenger/content/markByDate.js:63:17\n_fireButtonEvent@chrome://global/content/elements/dialog.js:487:19\n_doButtonCommand@chrome://global/content/elements/dialog.js:466:29\n_handleButtonCommand@chrome://global/content/elements/dialog.js:460:19\nMsgMarkReadByDate@chrome://messenger/content/mailWindowOverlay.js:2463:10\ndoCommand@chrome://messenger/content/mail3PaneWindowCommands.js:956:9\ndoCommand@chrome://messenger/content/mailTabs.js:844:23\ndoCommand@chrome://messenger/content/tabmail.js:564:27\ngoDoCommand@chrome://global/content/globalOverlay.js:101:18\noncommand@chrome://messenger/content/messenger.xhtml:1:12\n"
​
<prototype>: ExceptionPrototype { toString: toString(), name: Getter, message: Getter, … }
markByDate.js:121

Comment 4

[Magnus Melin [:mkmelin]]

Can you clarify the steps to reproduce?

Comment 5

[Tobias Weibel]

Attachment: Screen recording for mark as read --> exception

Comment 6

[Magnus Melin [:mkmelin]]

(Note to self, can be different on trunk since bug 1612239)

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to Tobias Weibel from comment #0)

I'm reading blogs through RSS in Thunderbird. I normally read the most interesting articles and then I press "C" to call "Mark Read by Date". Since version 78b2 (maybe b1) the mark as read doesn't work anymore. I still get the dialog to enter the two dates it won't mark the messages anymore. I normally just enter the "to date".

Can you confirm it also fails in b1? Use http://archive.mozilla.org/pub/thunderbird/releases/78.0b1/ You might need to use --allow-downgrade on command line to use the same profile

Comment 8

[Tobias Weibel]

I can confirm the bug in 78b1 as well.

Comment 9

[Tobias Weibel]

And the bug is fixed in 80.0b5 (already earlier, but that's my current version)

Comment 10

[Magnus Melin [:mkmelin]]

What about 78.2.0, the current release? If working, please close as WORKSFORME.

Comment 11

[Tobias Weibel]

I can confirm the bug for 78.1.1

Comment 12

[Magnus Melin [:mkmelin]]

So what about 78.2?

Comment 13

[Tobias Weibel]

Bug is still reproducible with 78.2.1

Comment 14

[red floyd]

Still reproducible in 78.5

Comment 15

[red floyd]

Here's the error from 78.5

16:42:01.917
Uncaught
Exception
​
columnNumber: 0
​
data: null
​
filename: "chrome://messenger/content/markByDate.js"
​
lineNumber: 121
​
location: XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), filename: Getter, name: Getter, … }
​
message: "Failure arg 0 [nsIMsgFolder.markMessagesRead]"
​
name: "NS_ERROR_FAILURE"
​
result: 2147500037
​
stack: "markInDatabase@chrome://messenger/content/markByDate.js:121:19\nonAccept@chrome://messenger/content/markByDate.js:63:17\n_fireButtonEvent@chrome://global/content/elements/dialog.js:487:19\n_doButtonCommand@chrome://global/content/elements/dialog.js:466:29\n_handleButtonCommand@chrome://global/content/elements/dialog.js:460:19\nMsgMarkReadByDate@chrome://messenger/content/mailWindowOverlay.js:2466:10\ndoCommand@chrome://messenger/content/mail3PaneWindowCommands.js:957:9\ndoCommand@chrome://messenger/content/mailTabs.js:844:23\ndoCommand@chrome://messenger/content/tabmail.js:577:27\ngoDoCommand@chrome://global/content/globalOverlay.js:101:18\noncommand@chrome://messenger/content/messenger.xhtml:1:12\n"
​
<prototype>: ExceptionPrototype { toString: toString(), name: Getter, message: Getter, … }
markByDate.js:121
markInDatabase chrome://messenger/content/markByDate.js:121
onAccept chrome://messenger/content/markByDate.js:63
_fireButtonEvent chrome://global/content/elements/dialog.js:487
_doButtonCommand chrome://global/content/elements/dialog.js:466
_handleButtonCommand chrome://global/content/elements/dialog.js:460
_handleButtonCommand self-hosted:844
MsgMarkReadByDate chrome://messenger/content/mailWindowOverlay.js:2466
doCommand chrome://messenger/content/mail3PaneWindowCommands.js:957
doCommand chrome://messenger/content/mailTabs.js:844
doCommand chrome://messenger/content/tabmail.js:577
goDoCommand chrome://global/content/globalOverlay.js:101
oncommand chrome://messenger/content/messenger.xhtml:1

​

Comment 17

[Magnus Melin [:mkmelin]]

Backing out https://hg.mozilla.org/comm-central/rev/96995bd8f55c685952d95b51fdb1c0a8f10c05a9 on 78 should fix it. On trunk it's working due to other changes in bug 1612239. Rob, can you take care

Comment 18

[Magnus Melin [:mkmelin]]

Regressed by bug 1612247

Comment 19

[Rob Lemley [:rjl]]

Thunderbird 78.6.0:
Backed out commit from comment 17 as requested (from bug 1612247):
https://hg.mozilla.org/releases/comm-esr78/rev/c010f2c127e8