Closed Bug 1648104 Opened 6 years ago Closed 1 year ago

Consider using WM_POINTER instead of WM_TOUCH for touch events

Categories

(Core :: Widget: Win32, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: edgar, Assigned: saschanaz)

References

Details

Attachments

(1 external file)

This is what Chromium does for touch events, https://source.chromium.org/chromium/chromium/src/+/master:ui/base/ui_base_features.cc;l=123-126;drc=1b9416763d475710d789915060b4c90d025ff61b?originalUrl=https:%2F%2Fcs.chromium.org%2F

WM_POINTER provides some additional information that is not able to get from WM_TOUCH for pointer events.

Note that consuming WM_TOUCH changes the coordinates of mouse cursor too; consuming WM_POINTER seems to make coordinates of each input device independent.

So consuming WM_POINTER does have the expected result of not changing mouse cursor position. But it seems this needs some APZ layer change as WM_POINTER do not collect multi touch pointers for us as WM_TOUCH does; each touch pointer will be reported independently. Currently just dispatching event for each pointer somehow deactivates the earlier but still active touch pointers.

Actually we already have a workaround and it works for this case too.

Assignee: nobody → krosylight
Attachment #9462899 - Attachment description: WIP: Bug 1648104 - Consume WM_POINTER with PT_TOUCH → Bug 1648104 - Consume WM_POINTER with PT_TOUCH r=edgar,#win-reviewers!
Status: NEW → ASSIGNED
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac9543274e5e Consume WM_POINTER with PT_TOUCH r=win-reviewers,rkraesig
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: