Closed Bug 1648154 Opened 4 years ago Closed 4 years ago

Migrate GeckoViewProgressChild.js to actor

Categories

(GeckoView :: General, enhancement, P1)

Unspecified
All
enhancement

Tracking

(firefox82 fixed)

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: agi, Assigned: agi)

References

(Blocks 1 open bug)

Details

(Whiteboard: [geckoview:m81][geckoview:m82])

Attachments

(4 files)

As part of the Fission work we need to migrate all our framescripts to Actors. This tracks the work needed to move GeckoViewProgressChild.js to a child actor.

Priority: -- → P2
Whiteboard: [geckoview:m80]
Severity: -- → S3
Priority: P2 → P1
Priority: P1 → P2
Whiteboard: [geckoview:m80] → [geckoview:m81]
Whiteboard: [geckoview:m81] → [geckoview:m81][geckoview:m82]
Assignee: nobody → agi
Regressions: 1661480
No longer regressions: 1661480

This patch tightens the coupling between the parent module and the child
actors.

Each parent module will receive messages from the corresponding child actors
whenever the parent actor does not define a message handler.

The parent actor also has the option to handle some messages and delegate the
rest by calling super.receiveMessage.

The idea is that every message that can be handled within the browsingContext
should be handled in the parent actor, while everything that needs context
across browsing contexts (e.g. page navigation listeners) should be handled in
the parent module.

Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b476a2a19046
Expose JSActor.name to javascript. r=nika
https://hg.mozilla.org/integration/autoland/rev/9f7864e3fd92
Forward child actor messages to the relevant module. r=esawin
https://hg.mozilla.org/integration/autoland/rev/166533fcff61
Use GeckoViewActorParent for existing actors. r=owlish
https://hg.mozilla.org/integration/autoland/rev/8681e4f0a1a4
Move GeckoViewProgressChild to actor. r=esawin

== Change summary for alert #26924 (as of Mon, 14 Sep 2020 05:09:54 GMT) ==

Improvements:

19% allrecipes ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable opt cold 3,109.79 -> 2,527.75

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26924

Regressions: 1667739
Regressions: 1672046
Regressions: 1672247
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: