1648385 - Allow search suggestions in the Urlbar when they are disabled by a pref but a restriction token or token alias is used

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Sviatoslav Abakumov [:Perlence]]

Attachment: sugg-off-question-yes.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

I have the Use the address bar for search and navigation option enabled. With Show search suggestions in address bar results disabled I've typed the search term in the address bar with the preceding question mark.

Actual results:

I don't see the search suggestions in address bar results.

Expected results:

I expected to see the suggestions in address bar results. This worked previously, perhaps it stopped since 77. I've also tested it in 79.0a1 (2020-06-24) and got the same result.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Marco Bonardo [:mak]]

Suggestions should be visible when a token alias or question mark are typed (when the urlbar is in search restriction mode), This likely means we don't have a test for this case.

Comment 3

[Harry Twyford]

Attachment: Bug 1648385 - Allow search suggestions in the Urlbar when they are disabled by a pref but a restriction token or token alias is used. r?adw

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1623637

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99e4b7a631a6
Allow search suggestions in the Urlbar when they are disabled by a pref but a restriction token or token alias is used. r=adw

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/99e4b7a631a6

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:harry, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Harry Twyford]

Comment on attachment 9159417 [details]
Bug 1648385 - Allow search suggestions in the Urlbar when they are disabled by a pref but a restriction token or token alias is used. r?adw

Beta/Release Uplift Approval Request

• User impact if declined: Regression where some users won't be able to get search suggestions in the address bar.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small frontend patch with multiple unit tests.
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9159417 [details]
Bug 1648385 - Allow search suggestions in the Urlbar when they are disabled by a pref but a restriction token or token alias is used. r?adw

Approved for 79.0b3. Thanks for including tests.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6b7ea9dbf405

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider fixing for ESR78 also or can this ride with release?

Comment 12

[Harry Twyford]

Comment on attachment 9159417 [details]
Bug 1648385 - Allow search suggestions in the Urlbar when they are disabled by a pref but a restriction token or token alias is used. r?adw

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This bug deals with accessing search suggestions in environments where suggestions are disabled in the address bar. It's my understanding that this is more likely in corporate environments, maybe due to group policy.

Moreover, this is a low-risk fix that might increase the volume of search suggestions, which is a positive.

• User impact if declined: Users who have search suggestions disabled in most cases in the address bar would have no way of accessing search suggestions even when trying to do so explicitly.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch affects just one provider component of the address bar. The address bar is pretty modular, so the chance of something going wrong elsewhere in the address bar is low/none. The change does not affect user data and is backed with several tests. This has baked on Nightly+Beta for almost two weeks and there's been no reported regressions.
• String or UUID changes made by this patch:

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9159417 [details]
Bug 1648385 - Allow search suggestions in the Urlbar when they are disabled by a pref but a restriction token or token alias is used. r?adw

More likely to bite users in enterprise environments. Approved for 78.1esr.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/41835a1ccf4b

Comment 16

[Drew Willcoxon :adw]

Resummarizing to better reflect the patch that landed.