Closed Bug 1648399 Opened 1 year ago Closed 5 months ago

Add tests for sane behaviour with unexpected LS and Cache files

Categories

(Core :: Storage: Quota Manager, task, P2)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: sg, Assigned: tt)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

There should be a test that asserts sane behaviour in case a user's profile has storage/permanent/chrome/ls or storage/permanent/chrome/cache files, which are not normally created by Firefox.

See also discussion in https://phabricator.services.mozilla.com/D77453#inline-464650

Tom, maybe you could give this a look?

Flags: needinfo?(ttung)

Sure thing and thanks!

Assignee: nobody → ttung
Severity: -- → S3
Flags: needinfo?(ttung)
Priority: -- → P3
Attachment #9160326 - Attachment description: Bug 1648399 - Tests to ensure that a cache/ls directory in permanet origin directory shouldn't cause storage init to fail; → Bug 1648399 - Add test cases to ensure that a cache/ls directory in permanet origin directory shouldn't cause storage init to fail;
Status: NEW → ASSIGNED
Attachment #9160326 - Attachment description: Bug 1648399 - Add test cases to ensure that a cache/ls directory in permanet origin directory shouldn't cause storage init to fail; → Bug 1648399 - Add test cases to ensure that a cache/ls directory in permanent origin directory shouldn't cause storage init to fail;
Priority: P3 → P2

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tt, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(ttung)

Thanks for the notice! A modified test inside is written in Bug 1647316, so it cannot be landed at the moment. I just reflect this on Bugzilla.

Depends on: 1647316
Flags: needinfo?(ttung)
Attachment #9160326 - Attachment description: Bug 1648399 - Add test cases to ensure that a cache/ls directory in permanent origin directory shouldn't cause storage init to fail; → WIP: Bug 1648399 - Add test cases to ensure that a cache/ls directory in permanent origin directory shouldn't cause storage init to fail;
Attachment #9160326 - Attachment description: WIP: Bug 1648399 - Add test cases to ensure that a cache/ls directory in permanent origin directory shouldn't cause storage init to fail; → Bug 1648399 - Add test cases to ensure that a cache/ls directory in permanent origin directory shouldn't cause storage init to fail;
Pushed by shes050117@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c1f839b8a6c4
Add test cases to ensure that a cache/ls directory in permanent origin directory shouldn't cause storage init to fail; r=dom-workers-and-storage-reviewers,sg,janv
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.