1648463 - Move SVGForeignObjectFrame SVGImageFrame and SVGUseFrame to the mozilla namespace

Status: RESOLVED FIXED

(Core :: SVG, task)

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1648463 - Move SVGForeignObjectFrame SVGImageFrame and SVGUseFrame to mozilla namespace

stop exporting SVGUseFrame as only dom/svg uses it and
stop exposing SVGImageListener as only SVGImageFrame uses it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/406930369866
Move SVGForeignObjectFrame SVGImageFrame and SVGUseFrame to mozilla namespace r=dholbert,jgilbert

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/406930369866

Comment 4

[Francois Guerraz]

Hello,

For me this leads to build failures:

 0:21.30 In file included from /mnt/BIG/francois/tmp/firefox-wayland-hg/src/mozilla-unified/dom/base/nsImageLoadingContent.cpp:46:
 0:21.30 /mnt/BIG/francois/tmp/firefox-wayland-hg/src/mozilla-unified/obj-x86_64-pc-linux-gnu/dist/include/mozilla/SVGImageFrame.h:59:3: error: no member named 'SVGImageFrame_id' in 'nsQueryFrame'
 0:21.30   NS_DECL_FRAMEARENA_HELPERS(SVGImageFrame)
 0:21.30   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 0:21.30 /mnt/BIG/francois/tmp/firefox-wayland-hg/src/mozilla-unified/obj-x86_64-pc-linux-gnu/dist/include/nsIFrame.h:590:26: note: expanded from macro 'NS_DECL_FRAMEARENA_HELPERS'
 0:21.30     return nsQueryFrame::class##_id; 

Comment 5

[Robert Longson [:longsonr]]

remove your obj directory and rebuild from scratch. Somehow your frame ids have not been regenerated by the python script.

Comment 6

[Francois Guerraz]

Ha, yes, that worked, thank you!

Comment 7

[Jonathan Kew [:jfkthame]]

Yeah, I just hit a build failure due to this, too; have clobbered and restarted the build. There must be some dependency missing from the build system, I guess....

Comment 8

[Robert Longson [:longsonr]]

Well it's layout/generic/FrameClasses.py that needs to be rerun to regenerate FrameIdList.h and FrameTypeList.h.

Comment 9

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

(In reply to Jonathan Kew (:jfkthame) from comment #7)

Yeah, I just hit a build failure due to this, too; have clobbered and restarted the build. There must be some dependency missing from the build system, I guess....

Filed bug 1648824.