16485 - Potential Y2k problem at nsFTPDirListingConv.cpp:778

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Anup Parkhi]

Please look at the following code at
./mozilla/netwerk/streamconv/converters/nsFTPDirListingConv.cpp:778

curTime.tm_year     = (((aCStr[6]-'0')*10) + aCStr[7]-'0');

The curTime is of type PRExplodedTime. The tm_year in PRExplodedTime represent
absolute year (four digit). It appears to me that RHS of the above statement
will result in two digit year only. Hence the curTime.tm_year will get assigned
the two digit year which i think does not match the defintion of tm_year in
PRExplodedTime.

Comment 1

[leger]

Assigning to valeski

Comment 2

[Judson Valeski]

I've got a fix. atatching...

Comment 3

[Judson Valeski]

Attachment: patch to fix y2k prob in dir listing conv

Comment 4

[Judson Valeski]

fix checked in 11/10/99 4:30pm pac time.

Comment 5

[shrirang khanzode]

Marking Verified/Fixed.

Comment 6

[Blake Ross]

moving to browser-general component.  the `Y2k' component is being retired...

Comment 7

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/dab4cb17e8a2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16485: Tabs tray grid view telemetry (https://github.com/mozilla-mobile/fenix/pull/17442)