Closed Bug 1648630 Opened 4 years ago Closed 4 years ago

Touch event isn't fired on Fission oop iframe

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla80
Fission Milestone M6b
Tracking Status
firefox80 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

STR:

  1. Enable fission
  2. Load https://codepen.io/edgarchen-the-decoder/pen/eYJWqRe
  3. Touch green area with finger on touch screen

Expected Result:
touch event logged

Actual Result:
No touch event logged

Fission Milestone: --- → ?
Severity: -- → S3
Priority: -- → P2

This was used in B2G and no one uses it now.

Assignee: nobody → echen
Status: NEW → ASSIGNED

Other than the layers id isn't set properly for touch events, I also found that maybe we have some other issues for multiple touches.
For multiple touches, per https://w3c.github.io/touch-events/#touchevent-implementer-s-note, all touch events should be dispatched to the same document that first touch event associated with. So for example, if we initialize the first touch inside iframe, and then initialize the second touch outside the iframe, the touch event of the second touch should be dispatch to iframe too.

(In reply to Edgar Chen [:edgar] from comment #5)

Other than the layers id isn't set properly for touch events, I also found that maybe we have some other issues for multiple touches.
For multiple touches, per https://w3c.github.io/touch-events/#touchevent-implementer-s-note, all touch events should be dispatched to the same document that first touch event associated with. So for example, if we initialize the first touch inside iframe, and then initialize the second touch outside the iframe, the touch event of the second touch should be dispatch to iframe too.

Okay, we suppress the touch that is outside the frame and we behave the same without Fission, so I think this is just what we behave now.

Fission Milestone: ? → M6b
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/70f5cc27a0c4
Part 1: Remove MultiTouchInput::ToWidgetMouseEvent; r=kats
https://hg.mozilla.org/integration/autoland/rev/e5c2bc278f07
Part 2: Use EvictTouches to evict old touches; r=kats
https://hg.mozilla.org/integration/autoland/rev/d23fbb1a4fd8
Part 3: Propagate layers id to touch event properly for Fission; r=kats
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: