1648718 - Selected date on calendar tab minimonth and views are not updated at midnight

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Geoff Lankow (:darktrojan)]

doMidnightUpdate calls getMinimonth().refreshDisplay() which should move the selected day and the "today" day forward at midnight, if the current day was selected. This should happen in showMonth but it does not, unless the month has changed. If the month has not changed, showMonth returns early.

Likewise, the calendar views should update the selected day, but they do not. They do update which day is marked as "today" though, where applicable.

This isn't a dupe of bug 1589023, but it is related.

Comment 1

[WaltS48 [:walts48]]

Testing 78.0rc (build2) on Ubuntu 18.04.4 Linux.

The Today pane and calendar updates to today after a few seconds upon waking from sleep, but the Mini-Month view still highlights the previous day and puts a border around the current day. A restart of Thunderbird fixes that issue.

I don't see any errors in my Error Console.

Comment 2

[Arthur K. (he/him)]

(In reply to WaltS48 [:walts48] from comment #1)

Testing 78.0rc (build2) on Ubuntu 18.04.4 Linux.

The Today pane and calendar updates to today after a few seconds upon waking from sleep, but the Mini-Month view still highlights the previous day and puts a border around the current day. A restart of Thunderbird fixes that issue.

I don't see any errors in my Error Console.

I just bumped up to the 78.0 RC2 build too. Going to do some testing tonight and leave my machine running all night without going to sleep as per bug 1589023#c72. I'll follow up in both bugs I suppose.

Comment 3

[Arthur K. (he/him)]

So between 11:30PM and 12:00AM, the only things in Error Console were below. Judging by that, it would seem mini-month has some other issue.

23:30:11.970 TypeError: impl is null network-response-listener.js:104:7
_forwardNotification resource://devtools/server/actors/network-monitor/network-response-listener.js:104
onProgress resource://devtools/server/actors/network-monitor/network-response-listener.js:391

00:00:11.680
XHRPOSThttps://accounts.google.com/o/oauth2/token [HTTP/2 200 OK 131ms]

00:00:11.842
XHRPOSThttps://accounts.google.com/o/oauth2/token [HTTP/2 200 OK 85ms]

00:00:11.842
REPORThttps://apidata.googleusercontent.com/caldav/v2/<removed>/events/ [HTTP/2 207 Multi-Status 232ms]

00:00:11.857
TypeError: impl is null5 network-response-listener.js:104:7
_forwardNotification resource://devtools/server/actors/network-monitor/network-response-listener.js:104
onStatus resource://devtools/server/actors/network-monitor/network-response-listener.js:395

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1648718 - Update "today" in mini-month even if the month is not redrawn. r=henry

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/db211b38b749
Update "today" in mini-month even if the month is not redrawn. r=henry

Comment 9

[Arthur K. (he/him)]

So this is still happening for me on 98.0b2 with a brand spanking new profile after I nuked my TB setup, profile and all related directories and started from scratch.

Error log from last night after I left and until I came in this morning and woke my PC shows:

18:12:14.097 TypeError: this._idleService is undefined imCore.jsm:142:20
_checkIdle resource:///modules/imCore.jsm:142
observe resource:///modules/imCore.jsm:112

08:15:50.977 carddav.sync: Sync with server failed. CardDAVDirectory.jsm:629:11
syncWithServer resource:///modules/CardDAVDirectory.jsm:629

08:15:51.079 uncaught exception: 2147500036

08:15:51.415 TypeError: this.uri is undefined2 calCachedCalendar.js:311:1
onResult resource:///components/calCachedCalendar.js:311
doWebDAVSync resource:///modules/caldav/CalDavRequestHandlers.jsm:438

8:15:51.436 NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "this.uri is undefined" {file: "resource:///components/calCachedCalendar.js" line: 311}]'[JavaScript Error: "this.uri is undefined" {file: "resource:///components/calCachedCalendar.js" line: 311}]' when calling method: [calIGenericOperationListener::onResult] 2 CalDavRequestHandlers.jsm:438

08:15:51.450 TypeError: this.uri is undefinedcalCachedCalendar.js:311:1
onResult resource:///components/calCachedCalendar.js:311
doWebDAVSync resource:///modules/caldav/CalDavRequestHandlers.jsm:438

Comment 10

[Geoff Lankow (:darktrojan)]

It's partially fixed but you're right, I didn't move the selection, missing half the point of my own bug.

Comment 11

[Arthur K. (he/him)]

(In reply to Geoff Lankow (:darktrojan) from comment #10)

It's partially fixed but you're right, I didn't move the selection, missing half the point of my own bug.

OK. Thought I was going nuts. Thanks for confirming Geoff.

Comment 12

[Arthur K. (he/him)]

For the past couple of days, 98.0b3 has been acting ok for me. Haven't had to restart TB in order for minimonth to move the date.

Comment 13

[Arthur K. (he/him)]

So I know this is now closed and the mini-month calendar appears to be working correct now. I no longer observe it not moving to the next day after midnight. However, I observed something today that floored me. My mini-month is highlighted as April 21st.

However, when I click New Event, it defaults to the date of April 19th. Running 100.0 b3 and I don't think I have exited and restarted TB in a while.

When I clicked New Event, Error Console shows > window.controllers/Controllers is deprecated. Do not use it for UA detection.

After I exited TB, restarted and the clicked New Event, it now defaults to April 21st. So while it displays it being on the right date, TB still thought it was two days ago until I restarted it.