Closed
Bug 1648846
Opened 4 years ago
Closed 4 years ago
test-linux.sh should not call xwit for Android tasks
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox80 fixed)
RESOLVED
FIXED
mozilla80
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: egao, Assigned: egao)
References
Details
Attachments
(1 file)
In android tests and tasks, under certain circumstances the conditional around the calling of xwit
command can produce failures when the display is not initialized for any reason.
[task 2020-06-26T17:41:05.572Z] # Bug 1607713 - set cursor position to 0,0 to avoid odd libx11 interaction
[task 2020-06-26T17:41:05.572Z] if [ ! -z $DISPLAY ]; then
[task 2020-06-26T17:41:05.572Z] xwit -root -warp 0 0
[task 2020-06-26T17:41:05.572Z] fi
[task 2020-06-26T17:41:05.572Z] + '[' '!' -z :0 ']'
[task 2020-06-26T17:41:05.572Z] + xwit -root -warp 0 0
[task 2020-06-26T17:41:05.572Z] xwit: unable to open display ':0'
[task 2020-06-26T17:41:05.572Z] xwit version 3.4
[task 2020-06-26T17:41:05.572Z]
[task 2020-06-26T17:41:05.572Z] usage: xwit -display <display> -sync
[task 2020-06-26T17:41:05.572Z] -pop -focus -iconify -unmap -print
[task 2020-06-26T17:41:05.572Z] -raise -lower -opposite -[un]circulate
[task 2020-06-26T17:41:05.572Z] -resize w h -rows r -columns c -[r]move x y
[task 2020-06-26T17:41:05.572Z] -[r]warp x y -colormap <colormapid> -[no]save
[task 2020-06-26T17:41:05.573Z] -name <name> -iconname <name> -property <lookfor>
[task 2020-06-26T17:41:05.573Z] -bitmap <file> -mask <file> -[r]iconmove x y
[task 2020-06-26T17:41:05.573Z] -[no]backingstore -[no]saveunder
[task 2020-06-26T17:41:05.573Z] -[no]keyrepeat keycode ... keycode - keycode
[task 2020-06-26T17:41:05.573Z] -id <windowid> -root -current -select -all
[task 2020-06-26T17:41:05.573Z] -names <initialsubstrings>... [must be last]
[task 2020-06-26T17:41:05.573Z] cleanup
[task 2020-06-26T17:41:05.573Z] + cleanup
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307686690&repo=autoland&lineNumber=448
The call to xwit
is intentionally outside of the $NEED_WINDOW_MANAGER
block to avoid subsequent calls affecting the cursor location.
The conditional to call xwit
should check additional criteria before continuing to call the command.
Assignee | ||
Updated•4 years ago
|
Component: Task Configuration → General
Product: Firefox Build System → Testing
Assignee | ||
Comment 1•4 years ago
|
||
Changes:
- instead of relying only on $DISPLAY env var, also use $NEED_WINDOW_MANAGER to the conditional
Pushed by egao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c41ce5de616e more robust detection in conditional for xwit to be called in test-linux.sh r=jmaher
Comment 3•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in
before you can comment on or make changes to this bug.
Description
•