1648846 - test-linux.sh should not call xwit for Android tasks

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Edwin Takahashi (:egao | infrequent contributor)]

In android tests and tasks, under certain circumstances the conditional around the calling of xwit command can produce failures when the display is not initialized for any reason.

[task 2020-06-26T17:41:05.572Z] # Bug 1607713 - set cursor position to 0,0 to avoid odd libx11 interaction
[task 2020-06-26T17:41:05.572Z] if [ ! -z $DISPLAY ]; then
[task 2020-06-26T17:41:05.572Z]     xwit -root -warp 0 0
[task 2020-06-26T17:41:05.572Z] fi
[task 2020-06-26T17:41:05.572Z] + '[' '!' -z :0 ']'
[task 2020-06-26T17:41:05.572Z] + xwit -root -warp 0 0
[task 2020-06-26T17:41:05.572Z] xwit:  unable to open display ':0'
[task 2020-06-26T17:41:05.572Z] xwit version 3.4
[task 2020-06-26T17:41:05.572Z] 
[task 2020-06-26T17:41:05.572Z] usage: xwit -display <display> -sync
[task 2020-06-26T17:41:05.572Z] 	-pop -focus -iconify -unmap -print 
[task 2020-06-26T17:41:05.572Z] 	-raise -lower -opposite -[un]circulate
[task 2020-06-26T17:41:05.572Z] 	-resize w h -rows r -columns c -[r]move x y
[task 2020-06-26T17:41:05.572Z] 	-[r]warp x y -colormap <colormapid> -[no]save
[task 2020-06-26T17:41:05.573Z] 	-name <name> -iconname <name> -property <lookfor>
[task 2020-06-26T17:41:05.573Z] 	-bitmap <file> -mask <file> -[r]iconmove x y
[task 2020-06-26T17:41:05.573Z] 	-[no]backingstore -[no]saveunder
[task 2020-06-26T17:41:05.573Z] 	-[no]keyrepeat keycode ... keycode - keycode
[task 2020-06-26T17:41:05.573Z] 	-id <windowid> -root -current -select -all
[task 2020-06-26T17:41:05.573Z] 	-names <initialsubstrings>... [must be last]
[task 2020-06-26T17:41:05.573Z] cleanup
[task 2020-06-26T17:41:05.573Z] + cleanup

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307686690&repo=autoland&lineNumber=448

The call to xwit is intentionally outside of the $NEED_WINDOW_MANAGER block to avoid subsequent calls affecting the cursor location.

The conditional to call xwit should check additional criteria before continuing to call the command.

Comment 1

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1648846 - more robust detection in conditional for xwit to be called in test-linux.sh

Changes:

• instead of relying only on $DISPLAY env var, also use $NEED_WINDOW_MANAGER to the conditional

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c41ce5de616e
more robust detection in conditional for xwit to be called in test-linux.sh r=jmaher

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c41ce5de616e