1648858 - Move d3.js from devtools/ to third_party/

Status: RESOLVED FIXED

(Toolkit :: General, task, P2)

Description

[Matthew N. [:MattN]]

Bug 1303176 would like to use d3-dsv for csvparse and that's already in-tree as part of d3.js so I think it makes sense to move it to toolkit so it can be shared.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1648858 - Replace reference to Makefile.in with moz.build in sqlite3/README.MOZILLA. r=Mossop

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1648858 - Allow BSD-3-Clause, CC0-1.0, Unlicense, WTFPL, & Zlib licenses in moz.yaml. r=mhoye

As far as I can tell this is allowed by the licensing runbook: https://docs.google.com/document/d/1Oguqp43W4_ChyroJ9AJAzG1jSwkUWfKvBKVvrDxVsMg/edit

Depends on D81435

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1648858 - Move d3.js from devtools/ to third_party/js/. r=Mossop

If you agree with vendoring in toolkit/vendor/ then I can also move others such as toolkit/components/jsoncpp and toolkit/components/protobuf.

Depends on D81436

Comment 4

[Matthew N. [:MattN]]

(In reply to Matthew N. [:MattN] from comment #3)

If you agree with vendoring in toolkit/vendor/ then I can also move others such as toolkit/components/jsoncpp and toolkit/components/protobuf.

I'm now starting to change my mind about this… maybe I should vendor in /third_party/js/d3/d3.js as I see other code not in toolkit/ that does chrome registration in toolkit.jar e.g. https://searchfox.org/mozilla-central/source/layout/style/jar.mn. My current patch would be adding one more place people could vendor, adding to the decision process and I'm not sure I see much benefit over toolkit/ if we're fine with a jar.mn in /third_party. Dave, which do you prefer? Or do you have another suggestion?

Comment 5

[Matthew N. [:MattN]]

Attachment: Bug 1648858 - Update d3.js to latest 3.x version (3.5.17). r=Mossop

We should upgrade to an even newer version but I don't want to break the devtools memory toolbox with a potential breaking change in 4.x.
This should allow using parts of d3.js without a document e.g. d3-dsv.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a9ae16f63c9
Replace reference to Makefile.in with moz.build in sqlite3/README.MOZILLA. r=mossop
https://hg.mozilla.org/integration/autoland/rev/f5770886187d
Allow BSD-3-Clause, CC0-1.0, Unlicense, WTFPL, & Zlib licenses in moz.yaml. r=mhoye
https://hg.mozilla.org/integration/autoland/rev/1622eb497b04
Move d3.js from devtools/ to toolkit/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/2a107eabe00c
Update d3.js to latest 3.x version (3.5.17). r=mossop

Comment 7

[Dorel Luca [:dluca]]

Backed out 4 changesets (bug 1648858) for Browser-chrome failures on content/test/static/browser_all_files_referenced.js. CLOSED TREE

Log:
https://hg.mozilla.org/integration/autoland/rev/0023408ef9059cb2bcf039014f2dce798c639185

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=2a107eabe00c53a826a8a17f172ed093c88a634e

Backout:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308160528&repo=autoland&lineNumber=2099

Comment 8

[Dave Townsend [:mossop]]

(In reply to Matthew N. [:MattN] from comment #4)

(In reply to Matthew N. [:MattN] from comment #3)

If you agree with vendoring in toolkit/vendor/ then I can also move others such as toolkit/components/jsoncpp and toolkit/components/protobuf.

I'm now starting to change my mind about this… maybe I should vendor in /third_party/js/d3/d3.js as I see other code not in toolkit/ that does chrome registration in toolkit.jar e.g. https://searchfox.org/mozilla-central/source/layout/style/jar.mn. My current patch would be adding one more place people could vendor, adding to the decision process and I'm not sure I see much benefit over toolkit/ if we're fine with a jar.mn in /third_party. Dave, which do you prefer? Or do you have another suggestion?

Oh sorry totally missed this. I think /third_party is probably a good options, though if you've already landed I don't think it's worth changing.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ae692d68b1b
Replace reference to Makefile.in with moz.build in sqlite3/README.MOZILLA. r=mossop
https://hg.mozilla.org/integration/autoland/rev/816eaac72512
Allow BSD-3-Clause, CC0-1.0, Unlicense, WTFPL, & Zlib licenses in moz.yaml. r=mhoye
https://hg.mozilla.org/integration/autoland/rev/3a1b5e883a4e
Move d3.js from devtools/ to third_party/js/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/5a612e42b77d
Update d3.js to latest 3.x version (3.5.17). r=mossop

Comment 10

[Matthew N. [:MattN]]

I'll go with third_party/js/ to simplify things a bit then.

Comment 11

[Razvan Maries]

Backed out for SM bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=IpYDIpidSzCweGDnZo5_Bg.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Csm&revision=5a612e42b77dde4a1af744750fbe9800d5edd455

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308266767&repo=autoland&lineNumber=6849

Backout: https://hg.mozilla.org/integration/autoland/rev/b49c44063786e5ada2764fae00cf9252a1c71f8b

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ccf9b057fe1
Replace reference to Makefile.in with moz.build in sqlite3/README.MOZILLA. r=mossop
https://hg.mozilla.org/integration/autoland/rev/36fe4ce13340
Allow BSD-3-Clause, CC0-1.0, Unlicense, WTFPL, & Zlib licenses in moz.yaml. r=mhoye
https://hg.mozilla.org/integration/autoland/rev/94f58715cbde
Move d3.js from devtools/ to third_party/js/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/8ead55149095
Update d3.js to latest 3.x version (3.5.17). r=mossop

Comment 13

[Matthew N. [:MattN]]

Don't think I've broken SM builds before…

Comment 14

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1648858) for causing toolchains bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=KxLyjUXGSxif4K8R1daU-w.0&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&searchStr=toolchains%2Copt%2Ctoolchain%2Cbuilds%2Cfor%2Cosx%2Ctoolchain-macosx64-minidump-stackwalk%2Ctm%28stackwalk%29&revision=8ead551490957cab6f77f400be2d5c4d2a342d72

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=308286093&repo=autoland

Backout: https://hg.mozilla.org/integration/autoland/rev/103be5eb16288d415bbbd343483d5291ce4928ea

Comment 15

[Matthew N. [:MattN]]

Try push with browser_all_files_referenced.js, SM, and stackwalk: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=f7dab2b8c3b7d7bcbef176a6ee99876eb88e542d

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05899359d009
Replace reference to Makefile.in with moz.build in sqlite3/README.MOZILLA. r=mossop
https://hg.mozilla.org/integration/autoland/rev/fe1888836b94
Allow BSD-3-Clause, CC0-1.0, Unlicense, WTFPL, & Zlib licenses in moz.yaml. r=mhoye
https://hg.mozilla.org/integration/autoland/rev/8f3bdf366147
Move d3.js from devtools/ to third_party/js/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/1de371f3cb2d
Update d3.js to latest 3.x version (3.5.17). r=mossop

Comment 17

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/05899359d009
https://hg.mozilla.org/mozilla-central/rev/fe1888836b94
https://hg.mozilla.org/mozilla-central/rev/8f3bdf366147
https://hg.mozilla.org/mozilla-central/rev/1de371f3cb2d