Closed Bug 1648957 Opened 4 years ago Closed 4 years ago

OpenPGP keyDetailsDlg structure: no subkeys shown

Categories

(MailNews Core :: Security: OpenPGP, defect)

defect

Tracking

(thunderbird78 fixed)

RESOLVED FIXED
Thunderbird 79.0
Tracking Status
thunderbird78 --- fixed

People

(Reporter: KaiE, Assigned: KaiE)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

This is a regression caused by https://hg.mozilla.org/comm-central/rev/637bcc4f8125
(scroll to the bottom, the very last change)

When opening the details of a key, the Structure tab shows incorrect information.

Because of the regression, it shows the primary key multiple times, and the subkeys aren't shown.

The fix is to revert that change.

Attached patch 1648957-v1.patchSplinter Review
Attachment #9159902 - Flags: review?(khushil324)
Comment on attachment 9159902 [details] [diff] [review]
1648957-v1.patch

Review of attachment 9159902 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch, Looks good to me. r=khushil.
Attachment #9159902 - Flags: review?(khushil324) → review+
Status: NEW → ASSIGNED

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/b09d47f88c80
OpenPGP keyDetailsDlg structure: no subkeys shown. r=Khushil DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 9159902 [details] [diff] [review]
1648957-v1.patch

Fixes an OpenPGP user interface regression
Attachment #9159902 - Flags: approval-comm-beta?
Comment on attachment 9159902 [details] [diff] [review]
1648957-v1.patch

Approved for beta
Attachment #9159902 - Flags: approval-comm-beta? → approval-comm-beta+
Target Milestone: --- → Thunderbird 79.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: