Closed Bug 1649098 Opened 5 years ago Closed 3 years ago

HG - MozPhab is updating the working directory twice for each commit

Categories

(Conduit :: moz-phab, defect, P3)

Product:
Conduit
Component:
moz-phab
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: zalun, Assigned: grammar)

References

(Blocks 1 open bug)

Details

(Keywords: conduit-triaged)

hg update <SHA1>
is called twice for each SHA1

We should check if that's required and change the behavior if possible.

Summary: MozPhab is updating the working directory twice for each commit → HG - MozPhab is updating the working directory twice for each commit
Assignee: nobody → grobertson
Status: NEW → ASSIGNED

hg update <SHA> is called when amending, which is done frequently, especially when users don't have evolve configured. However, any checks added at this point would not provide a considerable performance boost (i.e. running hg id -i to get the current revision and comparing that to the node passed in to the checkout method), or would require a not insignificant refactor to account for the differences between a user having evolve or not.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.