<a class="header-button" href="https://bugzilla.mozilla.org/home" title="Go to home page"> Bugzilla

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 10

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc2182995479 part 1) Add some documentation to `HTMLEditor::CreateDOMFragmentFromPaste`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/53a4b49e11f5 part 2) Factor moving start and end of out `CreateDOMFragmentForPaste`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/23136e9b0d91 part 3) Declare some methods in `HTMLEditor` `static`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/7cb690c8d208 part 4) Rename `HTMLEditUtils::IsTableElement` to `HTMLEditUtils::IsAnyTableElement`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/a87047c03047 part 5) Declare `HTMLEditor::GetBetterInsertionPointFor` `const`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/14fe3fb99221 part 6) Rename `HTMLEditUtils::IsTableElementButNotTable` to `HTMLEditUtils::IsAnyTableElementButNotTable`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/a50105f79fb0 part 7) Rename `HTMLEditUtils::IsList` to `HTMLEditUtils::IsAnyListElement`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/af63fd2828b5 part 8) Rename `CollectListAndTableRelatedElementsAt` to `CollectTableAndAnyListElementsOfInclusiveAncestorsAt`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/43481dc46b38 part 9) Simplify `GetMostAncestorListOrTableElement`. r=masayuki

Assignee

Updated

•

6 years ago

Keywords: leave-open

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 11

•

6 years ago

bugherder

Assignee

Comment 12

•

6 years ago

Attached file Bug 1649121: part 10) Remove redundant check in `HTMLEditor::DoInsertHTMLWithContext`. r=masayuki (obsolete) — Details

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 13

•

6 years ago

Attached file Bug 1649121: part 10) Rename `CollectTopMostChildNodesCompletelyInRange` to `CollectTopMostChildContentsCompletelyInRange`. r=masayuki — Details

Depends on D81847

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 14

•

6 years ago

Attached file Bug 1649121: part 11) Factor some functionality of `GetMostAncestorListOrTableElement` out. r=masayuki — Details

Depends on D81848

Updated

•

6 years ago

Attachment #9160639 - Attachment is obsolete: true

Updated

•

6 years ago

Attachment #9160640 - Attachment description: Bug 1649121: part 11) Rename `CollectTopMostChildNodesCompletelyInRange` to `CollectTopMostChildContentsCompletelyInRange`. r=masayuki → Bug 1649121: part 10) Rename `CollectTopMostChildNodesCompletelyInRange` to `CollectTopMostChildContentsCompletelyInRange`. r=masayuki

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Updated

•

6 years ago

Attachment #9160641 - Attachment description: Bug 1649121: part 12) Factor some functionality of `GetMostAncestorListOrTableElement` out. r=masayuki → Bug 1649121: part 11) Factor some functionality of `GetMostAncestorListOrTableElement` out. r=masayuki

Assignee

Comment 15

•

6 years ago

Attached file Bug 1649121: part 12) Remove duplicated code in `IsReplaceableListElement`. r=masayuki — Details

Depends on D81849

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 16

•

6 years ago

Attached file Bug 1649121: part 13) Rename `GetMostAncestorListOrTableElement`. r=masayuki — Details

Depends on D81993

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 17

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe84d83f7754 part 10) Rename `CollectTopMostChildNodesCompletelyInRange` to `CollectTopMostChildContentsCompletelyInRange`. r=masayuki

Assignee

Comment 18

•

6 years ago

Attached file Bug 1649121: part 14) Rename local variables `mostAncestorTableRelatedElement`, `maybeTableRelatedElement`. r=masayuki — Details

Depends on D81994

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 19

•

6 years ago

Attached file Bug 1649121: part 15) Declare `IsVisibleBRElement` `const`. r=masayuki — Details

Depends on D82008

Noemi Erli[:noemi_erli]

Comment 20

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/fe84d83f7754

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 21

•

6 years ago

Attached file Bug 1649121: part 16) Factor getting new caret point out of `DoInsertHTMLWithContext`. r=masayuki — Details

Depends on D82009

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 22

•

6 years ago

Attached file Bug 1649121: part 17) Correct style for previous commit. r=masayuki — Details

Separate commit to reduce possibility for typos.

Depends on D82147

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 23

•

6 years ago

Attached file Bug 1649121: part 18) Declare `CreateDOMFragmentFromPaste` `const`. r=masayuki — Details

Comment 24

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/660c40fe1d39 part 11) Factor some functionality of `GetMostAncestorListOrTableElement` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/bda80a47ba46 part 12) Remove duplicated code in `IsReplaceableListElement`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/3b45751665b9 part 13) Rename `GetMostAncestorListOrTableElement`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/a85194c541d6 part 14) Rename local variables `mostAncestorTableRelatedElement`, `maybeTableRelatedElement`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/65a677ea36d0 part 15) Declare `IsVisibleBRElement` `const`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/23d22d222e48 part 16) Factor getting new caret point out of `DoInsertHTMLWithContext`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/74f2d9c4261a part 17) Correct style for previous commit. r=masayuki

https://hg.mozilla.org/mozilla-central/rev/660c40fe1d39
https://hg.mozilla.org/mozilla-central/rev/bda80a47ba46
https://hg.mozilla.org/mozilla-central/rev/3b45751665b9
https://hg.mozilla.org/mozilla-central/rev/a85194c541d6
https://hg.mozilla.org/mozilla-central/rev/65a677ea36d0
https://hg.mozilla.org/mozilla-central/rev/23d22d222e48
https://hg.mozilla.org/mozilla-central/rev/74f2d9c4261a

Comment 25

•

6 years ago

bugherder

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 26

•

6 years ago

Attached file Bug 1649121: part 19) Add `HTMLWithContextInserter` and move content of `DoInsertHTMLWithContext` to it. r=masayuki — Details

This is minimally invasive. In the following parts, methods will be
moved to it and potentially other methods will be extracted.

Depends on D82198

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 27

•

6 years ago

Attached file Bug 1649121: part 20) Move `GetNewCaretPointAfterInsertingHTML` to `HTMLWithContextInserter`. r=masayuki — Details

Depends on D82384

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 28

•

6 years ago

Attached file Bug 1649121: part 21) Move `CreateDOMFragmentFromPaste`. r=masayuki — Details

Depends on D82385

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 29

•

6 years ago

Attached file Bug 1649121: part 22) Move `ParseFragment`. r=masayuki — Details

Depends on D82386

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 30

•

6 years ago

Attached file Bug 1649121: part 23) Move `MoveStartAndEndAccordingToHTMLInfo`. r=masayuki — Details

Depends on D82387

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 31

•

6 years ago

Attached file Bug 1649121: part 24) Move `StripFormattingNodes`. r=masayuki — Details

Depends on D82388

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 32

•

6 years ago

Attached file Bug 1649121: part 25) Factor detecting invisible `<br>` out. r=masayuki — Details

Depends on D82389

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 33

•

6 years ago

Attached file Bug 1649121: part 26) Move `CollectTopMostChildContentsCompletelyInRange`. r=masayuki — Details

Depends on D82517

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 34

•

6 years ago

Attached file Bug 1649121: part 27) Add `ShouldMoveCaretOutsideOfLink`. r=masayuki (obsolete) — Details

Depends on D82518

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 35

•

6 years ago

Attached file Bug 1649121: part 27) Add `MoveCaretOutsideOfLink`. r=masayuki — Details

Depends on D82519

Comment 36

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/233d95fb9fe4 part 18) Declare `CreateDOMFragmentFromPaste` `const`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/185be8f23283 part 19) Add `HTMLWithContextInserter` and move content of `DoInsertHTMLWithContext` to it. r=masayuki https://hg.mozilla.org/integration/autoland/rev/11acdf44634d part 20) Move `GetNewCaretPointAfterInsertingHTML` to `HTMLWithContextInserter`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/872032f12fe3 part 21) Move `CreateDOMFragmentFromPaste`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/13056466e78f part 22) Move `ParseFragment`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/610bc19ed14d part 23) Move `MoveStartAndEndAccordingToHTMLInfo`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/9aeb390dd46f part 24) Move `StripFormattingNodes`. r=masayuki

https://hg.mozilla.org/mozilla-central/rev/233d95fb9fe4
https://hg.mozilla.org/mozilla-central/rev/185be8f23283
https://hg.mozilla.org/mozilla-central/rev/11acdf44634d
https://hg.mozilla.org/mozilla-central/rev/872032f12fe3
https://hg.mozilla.org/mozilla-central/rev/13056466e78f
https://hg.mozilla.org/mozilla-central/rev/610bc19ed14d
https://hg.mozilla.org/mozilla-central/rev/9aeb390dd46f

Comment 37

•

6 years ago

bugherder

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 38

•

6 years ago

Attached file Bug 1649121: part 28) Add `InsertContents`. r=masayuki — Details

Its arguments are renamed in the following review.

Depends on D82520

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 39

•

6 years ago

Attached file Bug 1649121: part 29) Rename and simplify arguments of `InsertContents`. r=masayuki — Details

Depends on D82661

Updated

•

6 years ago

Attachment #9161851 - Attachment description: Bug 1649121: part 28) Add `MoveCaretOutsideOfLink`. r=masayuki → Bug 1649121: part 27) Add `MoveCaretOutsideOfLink`. r=masayuki

Updated

•

6 years ago

Attachment #9162079 - Attachment description: Bug 1649121: part 29) Add `InsertContents`. r=masayuki → Bug 1649121: part 28) Add `InsertContents`. r=masayuki

Updated

•

6 years ago

Attachment #9162080 - Attachment description: Bug 1649121: part 30) Rename and simplify arguments of `InsertContents`. r=masayuki → Bug 1649121: part 29) Rename and simplify arguments of `InsertContents`. r=masayuki

Updated

•

6 years ago

Attachment #9161850 - Attachment is obsolete: true

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 40

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/974d99b9cf36 part 25) Factor detecting invisible `<br>` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/71a1c9fdc933 part 26) Move `CollectTopMostChildContentsCompletelyInRange`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/964a4279b645 part 27) Add `MoveCaretOutsideOfLink`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/69092de8e958 part 28) Add `InsertContents`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/83eb0d717a70 part 29) Rename and simplify arguments of `InsertContents`. r=masayuki

Assignee

Comment 41

•

6 years ago

Attached file Bug 1649121: part 30) Move `RemoveBodyAndHead`, `FindTargetNode`. r=masayuki — Details

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 42

•

6 years ago

Attached file Bug 1649121: part 31) Change `StripFormattingNodes` to `RemoveNonPreWhiteSpaceOnlyTextNodesForIgnoringInvisibleWhiteSpaces`. r=masayuki — Details

Depends on D82885

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 43

•

6 years ago

Attached file Bug 1649121: part 32) Rename `RemoveBodyAndHead` to `RemoveHeadChildAndStealBodyChildsChildren`. r=masayuki — Details

More accurate, less misleading.

Depends on D82886

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 44

•

6 years ago

Attached file Bug 1649121: part 33) Rename `FindTargetNode` to `FindTargetNodeOfContextForPastedHTML`. r=masayuki — Details

Depends on D82894

Comment 45

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a820a72c43db part 30) Move `RemoveBodyAndHead`, `FindTargetNode`. r=masayuki

https://hg.mozilla.org/mozilla-central/rev/974d99b9cf36
https://hg.mozilla.org/mozilla-central/rev/71a1c9fdc933
https://hg.mozilla.org/mozilla-central/rev/964a4279b645
https://hg.mozilla.org/mozilla-central/rev/69092de8e958
https://hg.mozilla.org/mozilla-central/rev/83eb0d717a70
https://hg.mozilla.org/mozilla-central/rev/a820a72c43db

Comment 46

•

6 years ago

bugherder

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 47

•

6 years ago

Attached file Bug 1649121: part 34) Factor `FragmentParser` out. r=masayuki — Details

First step of separating parsing more clearly from other fragment
mutations.

Depends on D82895

Updated

•

6 years ago

Attachment #9162468 - Attachment description: Bug 1649121: part 32) Rename `RemoveBodyAndHead` to `RemoveHEADChildAndStealBODYChildsChildren`. r=masayuki → Bug 1649121: part 32) Rename `RemoveBodyAndHead` to `RemoveHeadChildAndStealBodyChildsChildren`. r=masayuki

Updated

•

6 years ago

Attachment #9162451 - Attachment description: Bug 1649121: part 31) Change `StripFormattingNodes` to `RemoveNonPREWhitespaceOnlyTextNodes`. r=masayuki → Bug 1649121: part 31) Change `StripFormattingNodes` to `RemoveNonPreWhiteSpaceOnlyTextNodesForIgnoringInvisibleWhiteSpaces`. r=masayuki

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 48

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b070fcc148f6 part 31) Change `StripFormattingNodes` to `RemoveNonPreWhiteSpaceOnlyTextNodesForIgnoringInvisibleWhiteSpaces`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/c805c09c2b28 part 32) Rename `RemoveBodyAndHead` to `RemoveHeadChildAndStealBodyChildsChildren`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/fdee379992c0 part 33) Rename `FindTargetNode` to `FindTargetNodeOfContextForPastedHTML`. r=masayuki

Assignee

Comment 49

•

6 years ago

Attached file Bug 1649121: part 35) Add `FragmentFromPasteCreator`. r=masayuki — Details

First step of breaking up the complex corresponding method.

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 50

•

6 years ago

Attached file Bug 1649121: part 36) Move setting start- and end-offsets out of `FragmentFromPasteCreator`. r=masayuki — Details

Depends on D83323

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 51

•

6 years ago

Attached file Bug 1649121: part 37) Move some methods to `FragmentFromPasteCreator`. r=masayuki — Details

Depends on D83324

Bogdan Tara[:bogdan_tara | bogdant]

Comment 52

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aad7c6b3d5ef part 34) Factor `FragmentParser` out. r=masayuki

Comment 53

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/b070fcc148f6
https://hg.mozilla.org/mozilla-central/rev/c805c09c2b28
https://hg.mozilla.org/mozilla-central/rev/fdee379992c0

https://hg.mozilla.org/mozilla-central/rev/aad7c6b3d5ef

Comment 54

•

6 years ago

bugherder

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=4d835cc17a7ff0ad08c5c3da1df70b470d709acf&selectedTaskRun=DnF9DFoqTKmk7Q4cx1XaxQ.0

Comment 55

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d835cc17a7f part 35) Add `FragmentFromPasteCreator`. r=masayuki

Razvan Maries

Comment 56

•

6 years ago

Backed out for build bustages.

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309701760&repo=autoland&lineNumber=14571

Backout: https://hg.mozilla.org/integration/autoland/rev/a77663b454d699d81a27e7180c64a086b08db788

Flags: needinfo?(mbrodesser)

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 57

•

6 years ago

Thanks for the notification. Will fix the build and land it again.

Flags: needinfo?(mbrodesser)

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 58

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d15ab3a0f771 part 35) Add `FragmentFromPasteCreator`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/1e127a5c1292 part 36) Move setting start- and end-offsets out of `FragmentFromPasteCreator`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/c4cd0750bfc4 part 37) Move some methods to `FragmentFromPasteCreator`. r=masayuki

Assignee

Comment 59

•

6 years ago

Attached file Bug 1649121: part 38) Add `CreateDocumentFragmentAndGetParentOfPastedHTMLInContext`. r=masayuki — Details

The parameters will be renamed in the following review.

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 60

•

6 years ago

Attached file Bug 1649121: part 39) Rename parameters and variables around `CreateDocumentFragmentAndGetParentOfPastedHTMLInContext`. r=masayuki — Details

Depends on D83515

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 61

•

6 years ago

Attached file Bug 1649121: part 40) Factor `DetermineContextLocalNameForParsingPastedHTML` out. r=masayuki — Details

Depends on D83516

Alexandru Michis [:malexandru]

Updated

•

6 years ago

Attachment #9163509 - Attachment description: Bug 1649121: part 39) Rename parameters and variables around `CreateDocumentFragmentAndTargetNodeForPaste`. r=masayuki → Bug 1649121: part 39) Rename parameters and variables around `CreateDocumentFragmentAndGetParentOfPastedHTMLInContext`. r=masayuki

Comment 62

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/d15ab3a0f771
https://hg.mozilla.org/mozilla-central/rev/1e127a5c1292
https://hg.mozilla.org/mozilla-central/rev/c4cd0750bfc4

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 63

•

6 years ago

Attached file Bug 1649121: part 41) Encapsulate content and node of parent of pasted HTML in context. r=masayuki (obsolete) — Details

Depends on D83517

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 64

•

6 years ago

Attached file Bug 1649121: part 41) Add local variable for pasted HTML document fragment. r=masayuki — Details

It's clearer and allow setting the output fragment at the end of the
method.

Depends on D83657

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 65

•

6 years ago

Attached file Bug 1649121: part 42) Factor `MergeAndPostProcessFragmentsForPastedHTMLAndContext` out. r=masayuki — Details

Depends on D83658

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 66

•

6 years ago

Attached file Bug 1649121: part 43) Factor `PostProcessFragmentForPastedHTMLWithoutContext` out. r=masayuki — Details

Depends on D83659

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 67

•

6 years ago

Attached file Bug 1649121: part 44) Factor `PreProcessContextDocumentFragmentForMerging` out. r=masayuki — Details

Depends on D83660

Comment 68

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17002265d035 part 38) Add `CreateDocumentFragmentAndGetParentOfPastedHTMLInContext`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/5cc856884937 part 39) Rename parameters and variables around `CreateDocumentFragmentAndGetParentOfPastedHTMLInContext`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/15f69af9b5b9 part 40) Factor `DetermineContextLocalNameForParsingPastedHTML` out. r=masayuki

Updated

•

6 years ago

Attachment #9163797 - Attachment is obsolete: true

Updated

•

6 years ago

Attachment #9163798 - Attachment description: Bug 1649121: part 42) Add local variable for pasted HTML document fragment. r=masayuki → Bug 1649121: part 41) Add local variable for pasted HTML document fragment. r=masayuki

Updated

•

6 years ago

Attachment #9163799 - Attachment description: Bug 1649121: part 43) Factor `MergeAndPostProcessFragmentsForPastedHTMLAndContext` out. r=masayuki → Bug 1649121: part 42) Factor `MergeAndPostProcessFragmentsForPastedHTMLAndContext` out. r=masayuki

Updated

•

6 years ago

Attachment #9163800 - Attachment description: Bug 1649121: part 44) Factor `PostProcessFragmentForPastedHTMLWithoutContext` out. r=masayuki → Bug 1649121: part 43) Factor `PostProcessFragmentForPastedHTMLWithoutContext` out. r=masayuki

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Updated

•

6 years ago

Attachment #9163801 - Attachment description: Bug 1649121: part 45) Factor `PreProcessContextDocumentFragmentForMerging` out. r=masayuki → Bug 1649121: part 44) Factor `PreProcessContextDocumentFragmentForMerging` out. r=masayuki

Assignee

Comment 69

•

6 years ago

Attached file Bug 1649121: part 45) Rename `FindTargetNodeOfContextForPastedHTML`. r=masayuki — Details

Depends on D83661

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 70

•

6 years ago

Attached file Bug 1649121: part 46) Reference spec in `nsINode::AppendChild`'s documentation. r=masayuki — Details

Depends on D83783

https://hg.mozilla.org/mozilla-central/rev/17002265d035
https://hg.mozilla.org/mozilla-central/rev/5cc856884937
https://hg.mozilla.org/mozilla-central/rev/15f69af9b5b9

Comment 71

•

6 years ago

bugherder

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 72

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ecae975d92fe part 41) Add local variable for pasted HTML document fragment. r=masayuki https://hg.mozilla.org/integration/autoland/rev/1b49d3b9e274 part 42) Factor `MergeAndPostProcessFragmentsForPastedHTMLAndContext` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/1b67973327ea part 43) Factor `PostProcessFragmentForPastedHTMLWithoutContext` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/499d2683b580 part 44) Factor `PreProcessContextDocumentFragmentForMerging` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/6b0161030c73 part 45) Rename `FindTargetNodeOfContextForPastedHTML`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/a8b504a946fa part 46) Reference spec in `nsINode::AppendChild`'s documentation. r=masayuki

Assignee

Comment 73

•

6 years ago

Attached file Bug 1649121: part 47) Rename local variable `startIsData` in `ContentIteratorBase::InitInternal`. r=masayuki — Details

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 74

•

6 years ago

Attached file Bug 1649121: part 48) Rename `MakeEmpty` in `ContentIteratorBase::InitInternal`. r=masayuki — Details

Depends on D83950

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 75

•

6 years ago

Attached file Bug 1649121: part 49) Break a method object out for `ContentIteratorBase::InitInternal`. r=masayuki — Details

Preparatory step to make that code readable.

Depends on D83951

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 76

•

6 years ago

Attached file Bug 1649121: part 50) Add members for start and end. r=masayuki — Details

Allows adding methods operating on them.

Depends on D83962

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 77

•

6 years ago

Attached file Bug 1649121: part 51) Factor `IsSingleNodeCharacterRange` out. r=masayuki — Details

Depends on D83963

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 78

•

6 years ago

Attached file Bug 1649121: part 52) Factor `IsCollapsedNonCharacterRange` out. r=masayuki — Details

Depends on D83964

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 79

•

6 years ago

Attached file Bug 1649121: part 53) Rename local variable `endIsData` in `ContentIteratorBase::InitInternal`. r=masayuki — Details

Depends on D83965

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 80

•

6 years ago

Attached file Bug 1649121: part 54) Add `RangeBoundaryBase::IsContainerAContainerHTMLElement`. r=masayuki (obsolete) — Details

Remove redundant code.

Depends on D83966

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 81

•

6 years ago

Attached file Bug 1649121: part 54) Assert range boundaries in `ContentIteratorBase::Initializer` are set and valid. r=masayuki — Details

Depends on D83967

https://hg.mozilla.org/mozilla-central/rev/ecae975d92fe
https://hg.mozilla.org/mozilla-central/rev/1b49d3b9e274
https://hg.mozilla.org/mozilla-central/rev/1b67973327ea
https://hg.mozilla.org/mozilla-central/rev/499d2683b580
https://hg.mozilla.org/mozilla-central/rev/6b0161030c73
https://hg.mozilla.org/mozilla-central/rev/a8b504a946fa

Comment 82

•

6 years ago

bugherder

Comment 83

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0ebea8897d47 part 47) Rename local variable `startIsData` in `ContentIteratorBase::InitInternal`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/8c5ca73547d0 part 48) Rename `MakeEmpty` in `ContentIteratorBase::InitInternal`. r=masayuki

Updated

•

6 years ago

Attachment #9164364 - Attachment description: Bug 1649121: part 54) Add `ContentIteratorBase::Initializer::IsContainer`. r=masayuki → Bug 1649121: part 54) Add `RangeBoundaryBase::IsContainerAContainerHTMLElement`. r=masayuki

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 84

•

6 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b38a02358eab part 49) Break a method object out for `ContentIteratorBase::InitInternal`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/6054a8df2932 part 50) Add members for start and end. r=masayuki https://hg.mozilla.org/integration/autoland/rev/ee2ef9d4d746 part 51) Factor `IsSingleNodeCharacterRange` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/f6b80f74f9ad part 52) Factor `IsCollapsedNonCharacterRange` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/a984435dc43a part 53) Rename local variable `endIsData` in `ContentIteratorBase::InitInternal`. r=masayuki

Assignee

Comment 85

•

6 years ago

Attached file Bug 1649121: part 56) Factor `DetermineFirstNode` out of `ContentIteratorBase::Initializer`. r=masayuki — Details

Hides details.

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 86

•

6 years ago

Attached file Bug 1649121: part 55) Factor `DetermineLastNode` out of `ContentIteratorBase::Initializer`. r=masayuki — Details

Hides details.

Depends on D84160

Narcis Beleuzu [:NarcisB]

Comment 87

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/0ebea8897d47
https://hg.mozilla.org/mozilla-central/rev/8c5ca73547d0

https://hg.mozilla.org/mozilla-central/rev/b38a02358eab
https://hg.mozilla.org/mozilla-central/rev/6054a8df2932
https://hg.mozilla.org/mozilla-central/rev/ee2ef9d4d746
https://hg.mozilla.org/mozilla-central/rev/f6b80f74f9ad
https://hg.mozilla.org/mozilla-central/rev/a984435dc43a

Comment 88

•

6 years ago

bugherder

Updated

•

5 years ago

Attachment #9164364 - Attachment is obsolete: true

Updated

•

5 years ago

Attachment #9164365 - Attachment description: Bug 1649121: part 55) Assert range boundaries in `ContentIteratorBase::Initializer` are set. r=masayuki → Bug 1649121: part 54) Assert range boundaries in `ContentIteratorBase::Initializer` are set and valid. r=masayuki

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Updated

•

5 years ago

Attachment #9164712 - Attachment description: Bug 1649121: part 57) Factor `DetermineLastNode` out of `ContentIteratorBase::Initializer`. r=masayuki → Bug 1649121: part 55) Factor `DetermineLastNode` out of `ContentIteratorBase::Initializer`. r=masayuki

Assignee

Comment 89

•

5 years ago

Attached file Bug 1649121: part 57) Change `DetermineFirstNode` to return the found node. r=masayuki — Details

Clearer.

Depends on D84160

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 90

•

5 years ago

Attached file Bug 1649121: part 58) Change `DetermineLastNode` to return the found node. r=masayuki — Details

Clearer.

Depends on D84370

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 91

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/68100e19a94d part 54) Assert range boundaries in `ContentIteratorBase::Initializer` are set and valid. r=masayuki https://hg.mozilla.org/integration/autoland/rev/a2bdc23f3e53 part 55) Factor `DetermineLastNode` out of `ContentIteratorBase::Initializer`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/2b525375be8d part 56) Factor `DetermineFirstNode` out of `ContentIteratorBase::Initializer`. r=masayuki

Assignee

Comment 92

•

5 years ago

Attached file Bug 1649121: part 59) Declare `mPre` `const`. r=masayuki — Details

Depends on D84371

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 93

•

5 years ago

Attached file Bug 1649121: part 60) Declare some methods in `ContentIteratorBase` `static`. r=masayuki — Details

Depends on D84491

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 94

•

5 years ago

Attached file Bug 1649121: part 61) Rename `mCommonParent` to `mClosestCommonInclusiveAncestor`. r=masayuki — Details

Depends on D84509

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 95

•

5 years ago

Attached file Bug 1649121: part 62) Replace `bool ContentIterator::mPre` with `enum class`. r=masayuki — Details

Depends on D84510

Natalia Csoregi [:nataliaCs]

Comment 96

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/68100e19a94d
https://hg.mozilla.org/mozilla-central/rev/a2bdc23f3e53
https://hg.mozilla.org/mozilla-central/rev/2b525375be8d

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 97

•

5 years ago

Attached file Bug 1649121: part 63) Factor `CacheInclusiveAncestorsOfEndContainer` out. r=masayuki — Details

Hides details and "inclusive" ancestors is more precise.

Depends on D84522

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 98

•

5 years ago

Attached file Bug 1649121: part 64) Don't reuse local `offset` variable in `InitWithRange`. r=masayuki — Details

Simplifies factoring determining firstCandidate and lastCandidate
out.

Depends on D84790

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 99

•

5 years ago

Attached file Bug 1649121: part 65) Declare more methods in `ContentIteratorBase` `static`. r=masayuki — Details

Depends on D84791

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 100

•

5 years ago

Attached file Bug 1649121: part 66) Factor `DetermineCandidateForFirstContent` out. r=masayuki — Details

Please see the next review too, because it moves more code to that
method.

Depends on D84792

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 101

•

5 years ago

Attached file Bug 1649121: part 67) Move more code to `DetermineCandidateForFirstContent`. r=masayuki — Details

Depends on D84793

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 102

•

5 years ago

Attached file Bug 1649121: part 68) Factor `DetermineFirstContent` out. r=masayuki — Details

Depends on D84794

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 103

•

5 years ago

Attached file Bug 1649121: part 69) Factor `DetermineCandidateForLastContent` out. r=masayuki — Details

Please see the following review too, because there more code is moved to
that method.

Depends on D84795

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 104

•

5 years ago

Attached file Bug 1649121: part 70) Move more code to `DetermineCandidateForLastContent`. r=masayuki — Details

Depends on D84831

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 105

•

5 years ago

Attached file Bug 1649121: part 71) Factor `DetermineLastContent` out. r=masayuki — Details

Depends on D84832

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 106

•

5 years ago

Attached file Bug 1649121: part 72) Rename `mEndNodes` to `mInclusiveAncestorsOfEndContainer`. r=masayuki — Details

Depends on D84833

Comment 107

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/885508b7a15c part 57) Change `DetermineFirstNode` to return the found node. r=masayuki https://hg.mozilla.org/integration/autoland/rev/24cc8c0b96bc part 58) Change `DetermineLastNode` to return the found node. r=masayuki https://hg.mozilla.org/integration/autoland/rev/ff333a51931f part 59) Declare `mPre` `const`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/3894d20e0f0b part 60) Declare some methods in `ContentIteratorBase` `static`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/d374d8692104 part 61) Rename `mCommonParent` to `mClosestCommonInclusiveAncestor`. r=masayuki

Updated

•

5 years ago

Attachment #9165847 - Attachment description: Bug 1649121: part 63) Factor `CacheEndContainersInclusiveAncestors` out. r=masayuki → Bug 1649121: part 63) Factor `CacheInclusiveAncestorsOfEndContainer` out. r=masayuki

Updated

•

5 years ago

Attachment #9165928 - Attachment description: Bug 1649121: part 72) Rename `mEndNodes` to `mEndContainersInclusiveAncestors`. r=masayuki → Bug 1649121: part 72) Rename `mEndNodes` to `mInclusiveAncestorsOfEndContainer`. r=masayuki

Comment 108

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e4b86d02431 part 62) Replace `bool ContentIterator::mPre` with `enum class`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/36f2d1a081f5 part 63) Factor `CacheInclusiveAncestorsOfEndContainer` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/204dcb26837f part 64) Don't reuse local `offset` variable in `InitWithRange`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/3509bd105db8 part 65) Declare more methods in `ContentIteratorBase` `static`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/5002d651b711 part 66) Factor `DetermineCandidateForFirstContent` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/39033ca494c1 part 67) Move more code to `DetermineCandidateForFirstContent`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/2dfb66728bdf part 68) Factor `DetermineFirstContent` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/e9a3849e624c part 69) Factor `DetermineCandidateForLastContent` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/88a2963f2cf4 part 70) Move more code to `DetermineCandidateForLastContent`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/6fee5dd104d1 part 71) Factor `DetermineLastContent` out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/03646d5e16ac part 72) Rename `mEndNodes` to `mInclusiveAncestorsOfEndContainer`. r=masayuki

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 109

•

5 years ago

bugherder

Assignee

Comment 110

•

5 years ago

Attached file Bug 1649121: part 73) Factor `IsNodeContainedInRange` out. r=masayuki — Details

Removes code duplication, abstracts details away.

Comment 111

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0b9bfa8ca7c part 73) Factor `IsNodeContainedInRange` out. r=masayuki

https://hg.mozilla.org/mozilla-central/rev/e0b9bfa8ca7c

Comment 112

•

5 years ago

bugherder

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 113

•

5 years ago

Attached file Bug 1649121: part 74) Pass `Document` instead of `HTMLEditor` to `CreateDocumentFragmentFromPaste`. r=masayuki — Details

CreateDocumentFragmentFromPaste doesn't need to know about
HTMLEditor, Document suffices.

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 114

•

5 years ago

Attached file Bug 1649121: part 75) Declare `FragmentFromPasteCreator`'s `Document` argument `const`. r=masayuki — Details

Simplifies reasoning about it.

Depends on D88118

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 115

•

5 years ago

Attached file Bug 1649121: part 76) Factor `IsInsertionCookie` out. r=masayuki — Details

Depends on D88119

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 116

•

5 years ago

Attached file Bug 1649121: part 77) `MOZ_ASSERT` html info is only provided when there's html context. r=masayuki — Details

Depends on D88247

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 117

•

5 years ago

Attached file Bug 1649121: part 78) Revert part 77. r=masayuki — Details

It's more concise.

Depends on D88257

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 118

•

5 years ago

Attached file Bug 1649121: part 79) Pass reference to `IncludeInContext` instead of pointer. r=masayuki — Details

It's clearer.

Depends on D88258

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 119

•

5 years ago

Attached file Bug 1649121: part 80) Factor determing start- and end-content out of `SerializeRangeNodes`. r=masayuki — Details

Hides details.

Depends on D88259

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 120

•

5 years ago

Attached file Bug 1649121: part 81) Factor serializing text node out of `RangeSerializer`. r=masayuki — Details

Hides details.

Depends on D88260

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 121

•

5 years ago

Attached file Bug 1649121: part 82) Factor serializing node partially contained in range out. r=masayuki — Details

Hides details. The new methods' arguments are renamed in the next
review.

Depends on D88261

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 122

•

5 years ago

Attached file Bug 1649121: part 83) Rename arguments of `SerializeNodePartiallyContainedInRange` to conform to style-guide. r=masayuki — Details

Depends on D88262

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 123

•

5 years ago

Attached file Bug 1649121: part 84) Change some arguments of `SerializeNodePartiallyContainedInRange` from pointers to references. r=masayuki — Details

Clearer.

Depends on D88263

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 124

•

5 years ago

Attached file Bug 1649121: part 85) Follow-up for part 74. r=masayuki — Details

Depends on D88428

Comment 125

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b9bcdf8a7967 part 74) Pass `Document` instead of `HTMLEditor` to `CreateDocumentFragmentFromPaste`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/d139830f70b9 part 75) Declare `FragmentFromPasteCreator`'s `Document` argument `const`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/a7344f8a1e30 part 76) Factor `IsInsertionCookie` out. r=masayuki

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Updated

•

5 years ago

Attachment #9172122 - Attachment description: Bug 1649121: part 82) Factor serializing node partially contained in range out. → Bug 1649121: part 82) Factor serializing node partially contained in range out. r=masayuki

Assignee

Comment 126

•

5 years ago

Attached file Bug 1649121: part 86) Follow-up for part 79. r=masayuki — Details

Depends on D88430

https://hg.mozilla.org/mozilla-central/rev/b9bcdf8a7967
https://hg.mozilla.org/mozilla-central/rev/d139830f70b9
https://hg.mozilla.org/mozilla-central/rev/a7344f8a1e30
https://hg.mozilla.org/mozilla-central/rev/25f72d16044a

Comment 127

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/25f72d16044a part 77) `MOZ_ASSERT` html info is only provided when there's html context. r=masayuki

Cosmin Sabou [:CosminS]

Comment 128

•

5 years ago

bugherder

Updated

•

5 years ago

Attachment #9172118 - Attachment description: Bug 1649121: part 78) Move start- and end-node only if html context was provided. r=masayuki → Bug 1649121: part 78) Revert part 77. r=masayuki

Bogdan Tara[:bogdan_tara | bogdant]

Comment 129

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/afa9f0262aa6 part 78) Revert part 77. r=masayuki https://hg.mozilla.org/integration/autoland/rev/6876eb48d2ed part 79) Pass reference to `IncludeInContext` instead of pointer. r=masayuki https://hg.mozilla.org/integration/autoland/rev/c555095f6604 part 80) Factor determing start- and end-content out of `SerializeRangeNodes`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/7cd7d4aaa4e9 part 81) Factor serializing text node out of `RangeSerializer`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/23320dfa3110 part 82) Factor serializing node partially contained in range out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/0ab368e868cd part 83) Rename arguments of `SerializeNodePartiallyContainedInRange` to conform to style-guide. r=masayuki https://hg.mozilla.org/integration/autoland/rev/e342a0f97d2c part 84) Change some arguments of `SerializeNodePartiallyContainedInRange` from pointers to references. r=masayuki https://hg.mozilla.org/integration/autoland/rev/6ff7f090eeb6 part 85) Follow-up for part 74. r=masayuki https://hg.mozilla.org/integration/autoland/rev/ec0dd01a8333 part 86) Follow-up for part 79. r=masayuki

Comment 130

•

5 years ago

bugherder

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 131

•

5 years ago

Attached file Bug 1649121: part 87) Add minimal documentation to `HTMLEditor::ParseCFHTML`. r=masayuki — Details

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 132

•

5 years ago

Attached file Bug 1649121: part 88) Declare some methods around `DataTransfer` `const`. r=masayuki — Details

Helps reasoning about them.

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 133

•

5 years ago

Attached file Bug 1649121: part 89) Reference spec from `DataTransfer` class. r=masayuki — Details

Clarifies the connection.

Depends on D90528

Comment 134

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4756124ec03 part 87) Add minimal documentation to `HTMLEditor::ParseCFHTML`. r=masayuki

Alexandru Michis [:malexandru]

Comment 135

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1036d28621b9 part 88) Declare some methods around `DataTransfer` `const`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/60ce423cd417 part 89) Reference spec from `DataTransfer` class. r=masayuki

Comment 136

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/e4756124ec03
https://hg.mozilla.org/mozilla-central/rev/1036d28621b9
https://hg.mozilla.org/mozilla-central/rev/60ce423cd417

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 137

•

5 years ago

Attached file Bug 1649121: part 90) Declare some editor methods `const` or `static`. r=m_kato — Details

Simplifies reasoning about them.

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 138

•

5 years ago

Attached file Bug 1649121: part 91) Document some arguments of some `DataTransfer`-related methods. r=m_kato — Details

A step towards making HTMLEditor::InsertFromDataTransfer
understandable.

Depends on D90688

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 139

•

5 years ago

Attached file Bug 1649121: part 92) Factor `HTMLTransferablePreparer` out. r=m_kato — Details

Preparing the transferable has the hidden requirement that the order of
the added flavors matters.

This is the preparation for expressing this in code.

aTransferable is renamed in the following commit.

Depends on D90689

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 140

•

5 years ago

Attached file Bug 1649121: part 93) Change `aTransferable` to `mTransferable`. r=m_kato — Details

To adhere the style-guide.

Depends on D90881

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 141

•

5 years ago

Attached file Bug 1649121: part 94) Factor adding flavors in best order out. r=m_kato — Details

This clarifies why the flavors are added in a certain order and why
retrieving the first available one is the best one.

Moreover, this enables previously, accidentally disabled
NS_WARNING_ASSERTIONS.

Depends on D90882

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 142

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96a3d02b5ba9 part 90) Declare some editor methods `const` or `static`. r=m_kato https://hg.mozilla.org/integration/autoland/rev/96b7ecdffe87 part 91) Document some arguments of some `DataTransfer`-related methods. r=m_kato

Assignee

Comment 143

•

5 years ago

Attached file Bug 1649121: part 95) Update `ElementInfo`'s documentation. r=m_kato — Details

Helps understanding the members.

Depends on D90883

Bogdan Tara[:bogdan_tara | bogdant]

Comment 144

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4db50381fa96 part 92) Factor `HTMLTransferablePreparer` out. r=m_kato https://hg.mozilla.org/integration/autoland/rev/081bc411deaf part 93) Change `aTransferable` to `mTransferable`. r=m_kato https://hg.mozilla.org/integration/autoland/rev/eedf67df5cde part 94) Factor adding flavors in best order out. r=m_kato

Comment 145

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/96a3d02b5ba9
https://hg.mozilla.org/mozilla-central/rev/96b7ecdffe87

https://hg.mozilla.org/mozilla-central/rev/4db50381fa96
https://hg.mozilla.org/mozilla-central/rev/081bc411deaf
https://hg.mozilla.org/mozilla-central/rev/eedf67df5cde

Comment 146

•

5 years ago

bugherder

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316565656&repo=mozilla-central&lineNumber=78678

Comment 147

•

5 years ago

Backed out 3 changesets (bug 1649121) for Build bustage in editor/libeditor/HTMLEditorDataTransfer.cpp. CLOSED TREE

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&group_state=expanded&revision=7b98b01d238e1581d109397b51ba3356568e6566&selectedTaskRun=VFMPJVq4Tmyd7zFbQlBZ2w.0

Backout:
https://hg.mozilla.org/integration/autoland/rev/c4a7d4ddb69906f225c0a938166fb1eba3b3b5b0

Flags: needinfo?(mbrodesser)

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Comment 148

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76fd642685d9 part 92) Factor `HTMLTransferablePreparer` out. r=m_kato https://hg.mozilla.org/integration/autoland/rev/f24176c12b4f part 93) Change `aTransferable` to `mTransferable`. r=m_kato https://hg.mozilla.org/integration/autoland/rev/68da14e95f85 part 94) Factor adding flavors in best order out. r=m_kato

Assignee

Updated

•

5 years ago

Flags: needinfo?(mbrodesser)

https://hg.mozilla.org/mozilla-central/rev/76fd642685d9
https://hg.mozilla.org/mozilla-central/rev/f24176c12b4f
https://hg.mozilla.org/mozilla-central/rev/68da14e95f85

Comment 149

•

5 years ago

bugherder

Alexandru Michis [:malexandru]

Comment 150

•

5 years ago

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fed78f7745b7 part 95) Update `ElementInfo`'s documentation. r=m_kato

Comment 151

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/fed78f7745b7

Mirko Brodesser (:mbrodesser) -- not reading bugmails currently

Assignee

Comment 152

•

5 years ago

Attached file Bug 1649121: part 96) Extend documentation of `synthesizeMouse` and `synthesizeMouseAtPoint`. r=masayuki — Details