Closed Bug 1649131 Opened 6 years ago Closed 6 years ago

Make history.pushState work with session history in the parent

Categories

(Core :: DOM: Navigation, task)

task

Tracking

()

RESOLVED FIXED
82 Branch
Fission Milestone M6b
Tracking Status
firefox82 --- fixed

People

(Reporter: peterv, Assigned: peterv)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

No description provided.
Severity: -- → S3
Fission Milestone: --- → M6b
Depends on: 1654525
Blocks: 1656347

The entries in the parent process stores some data in a shared state for some of
the entries that share a document. We also need to store some of this data in
the info objects in the child process, but it doesn't make sense to have it be
shared: the data shouldn't be mutated in the child process, and we probably only
have one of the info objects anyway. This adds a structure that holds the shared
data for an info object in the child process, but without actually sharing it.
As we use info objects in both parent and child, we hold a void pointer that's a
strong reference to a shared state in the parent process, and an owning pointer
to the pseudo-shared state in the child process.

Depends on D87037

Attachment #9169966 - Attachment description: Bug 1649131 - Pass a flag to know whether we're loading from a session history entry. r?smaug! → Bug 1649131 - Stop checking for an nsISHEntry in nsDocShellLoadState as a sign of a load from history. r?smaug!
Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e8c5bcb36bd5 Stop marking SessionHistoryInfo as moveonly. r=smaug https://hg.mozilla.org/integration/autoland/rev/26e4fadc89e6 Stop checking for an nsISHEntry in nsDocShellLoadState as a sign of a load from history. r=smaug https://hg.mozilla.org/integration/autoland/rev/9b0eba610209 Store some data in a pseudo shared state in the child process. r=smaug https://hg.mozilla.org/integration/autoland/rev/ca939d74f849 Implement history.pushState/.replaceState for session history in the parent. r=smaug
Blocks: 1661266
Regressions: 1663452
Regressions: 1672873
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: