Create a file in browser/components/urlbar to handle Places queries for Urlbar providers
Categories
(Firefox :: Address Bar, task, P3)
Tracking
()
People
(Reporter: bugzilla, Unassigned)
References
Details
Attachments
(1 obsolete file)
Bug 1648468 will add UrlbarProviderAutofill
, which will be the first Urlbar provider (other than the proof-of-concept UrlbarProviderOpenTabs
) to query Places directly. We should create a file that contains SQL queries, indices, and helper functions to create DB connections for UrlbarProviders. I was thinking UrlbarPlacesQueries.jsm
could work as a name but UrlbarDatabaseUtils
or UrlbarPlacesUtils
could work as well.
Comment 1•4 years ago
|
||
PlacesQueries may be confusing since there's place: urls that resolve to queries objects in Places. I think UrlbarDatabaseUtils will be fine as a name.
Comment 2•4 years ago
|
||
Anyway, I'd like to understand what will be contained here, since the connection is already shared through PlacesUtils and statements are cached in Sqlite.jsm. Why not having each provider contain its own SQL?
Updated•4 years ago
|
Reporter | ||
Comment 3•4 years ago
|
||
You make good points. I changed my patch to keep Autofill SQL in UrlbarProviderAutofill
. UrlbarDatabaseUtils.jsm
still exists, but it's quite small: it stores query indices, mostly. My patch should be up shortly.
Reporter | ||
Comment 4•4 years ago
|
||
Depends on D80295
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Harry, what's the status here? Do we still need this?
Reporter | ||
Comment 6•4 years ago
|
||
Nope! This ended up getting factored into bug 1648468.
Description
•