Closed Bug 1649162 Opened 4 years ago Closed 4 years ago

Create a file in browser/components/urlbar to handle Places queries for Urlbar providers

Categories

(Firefox :: Address Bar, task, P3)

task
Points:
2

Tracking

()

RESOLVED INVALID
Iteration:
80.1 - June 29 - July 12

People

(Reporter: bugzilla, Unassigned)

References

Details

Attachments

(1 obsolete file)

Bug 1648468 will add UrlbarProviderAutofill, which will be the first Urlbar provider (other than the proof-of-concept UrlbarProviderOpenTabs) to query Places directly. We should create a file that contains SQL queries, indices, and helper functions to create DB connections for UrlbarProviders. I was thinking UrlbarPlacesQueries.jsm could work as a name but UrlbarDatabaseUtils or UrlbarPlacesUtils could work as well.

PlacesQueries may be confusing since there's place: urls that resolve to queries objects in Places. I think UrlbarDatabaseUtils will be fine as a name.

Anyway, I'd like to understand what will be contained here, since the connection is already shared through PlacesUtils and statements are cached in Sqlite.jsm. Why not having each provider contain its own SQL?

Severity: -- → S3
Type: enhancement → task
Priority: -- → P3

You make good points. I changed my patch to keep Autofill SQL in UrlbarProviderAutofill. UrlbarDatabaseUtils.jsm still exists, but it's quite small: it stores query indices, mostly. My patch should be up shortly.

Points: 5 → 2

Depends on D80295

Attachment #9161338 - Attachment is obsolete: true

Harry, what's the status here? Do we still need this?

Flags: needinfo?(htwyford)

Nope! This ended up getting factored into bug 1648468.

Assignee: htwyford → nobody
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(htwyford)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: