Closed Bug 1649236 Opened 3 months ago Closed 3 months ago

Separator in Library is invisible/not visible after landing patch from bug #1642239

Categories

(Firefox :: Bookmarks & History, defect, P2)

79 Branch
x86_64
Windows 7
defect

Tracking

()

VERIFIED FIXED
Firefox 80
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox77 --- unaffected
firefox78 --- unaffected
firefox79 --- verified
firefox80 --- verified

People

(Reporter: Virtual, Assigned: itiel_yn8)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(3 files)

STR:

  1. Open Mozilla Firefox
  2. Open Library
  3. Add Separator
    and see that it's invisible/not visible

Regression caused by:
bug #1642239 - Convert PNG/GIF icons in the library window and editbookmark panel to SVG r=dao

Differential Revision:
https://phabricator.services.mozilla.com/D77622

Flags: needinfo?

Thanks for the report!

Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Flags: needinfo?(itiel_yn8)

Thanks for confirming!

Flags: needinfo?(itiel_yn8)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b969b02fb00
Fix the separators being invisible in the Library r=dao
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
Severity: -- → S4
Flags: qe-verify+

Comment on attachment 9160197 [details]
Bug 1649236 - Fix the separators being invisible in the Library r?dao

Beta/Release Uplift Approval Request

  • User impact if declined: Bookmark separators are invisible in the library on Windows 7
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment 0
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial patch, reverting part of the patch that caused this
  • String changes made/needed:
Attachment #9160197 - Flags: approval-mozilla-beta?

Comment on attachment 9160197 [details]
Bug 1649236 - Fix the separators being invisible in the Library r?dao

Approved for 79.0b3.

Attachment #9160197 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 80.0a1 (2020-07-02) and in latest build of Mozilla Firefox 79.
Thank you very much! \o/

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.