1649236 - Separator in Library is invisible/not visible after landing patch from bug #1642239

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

STR:

1. Open Mozilla Firefox
2. Open Library
3. Add Separator
   and see that it's invisible/not visible

Regression caused by:
bug #1642239 - Convert PNG/GIF icons in the library window and editbookmark panel to SVG r=dao

Differential Revision:
https://phabricator.services.mozilla.com/D77622

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bad.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: good.png

Comment 3

[Itiel]

Thanks for the report!

Comment 4

[Itiel]

Attachment: Bug 1649236 - Fix the separators being invisible in the Library r?dao

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

FYI - I'm not able to reproduce bug with try build created by Dão Gottwald from https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b4f65e60e983f56e58ce5c812cd2f60f7c7a87a (Built from https://hg.mozilla.org/try/rev/6b4f65e60e983f56e58ce5c812cd2f60f7c7a87a)

Comment 6

[Itiel]

Thanks for confirming!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b969b02fb00
Fix the separators being invisible in the Library r=dao

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/4b969b02fb00

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9160197 [details]
Bug 1649236 - Fix the separators being invisible in the Library r?dao

Beta/Release Uplift Approval Request

• User impact if declined: Bookmark separators are invisible in the library on Windows 7
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch, reverting part of the patch that caused this
• String changes made/needed:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9160197 [details]
Bug 1649236 - Fix the separators being invisible in the Library r?dao

Approved for 79.0b3.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a0161364227e

Comment 12

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 80.0a1 (2020-07-02) and in latest build of Mozilla Firefox 79.
Thank you very much! \o/