164924 - Large .hqx file data not completely transfered via the Download dialog

Status: VERIFIED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Chris Petersen]

Build: 2002-08-27-05
Platform: OS X 10.2 (6C115)

Expected Results: The File that is created should be the size as mentioned in
D/L 's Status area (69 MB)
What I got: After the transfer is completed, the file's size is around 50 MB and
and can't be open in Stuffit Expander.

Steps to reproduce:

1) Go to http://download.macromedia.com/pub/dreamweaver/esd/dw_mx_trial_en.hqx.

2) Specify location for file and click Save.

3) Notice the Status area states file as 69 MB.

4) When file is transfered, the status area states file as 50 MB.

Comment 1

[Mike Pinkerton (not reading bugmail)]

petersen, did this regress recently or has it been a long-standing problem?
sounds like's it's related to the other bugs about downloads not thinking
they're complete, etc 

over to brade for a look.

Comment 2

[Chris Petersen]

I'm working on this now. It try the 0.4.0 release and go from there.

Comment 3

[Chris Petersen]

It's not a regression since I can reproduce it in the 0.4.0 release.

Comment 4

[sairuh (rarely reading bugmail)]

could this be related to bug 164917?

Comment 5

[Simon Fraser [no longer active]]

Does the failed download always have the exact same size?

Comment 6

[Chris Petersen]

Yes, I always get a 50 mb file size (50.5 MB - 53,047,524 bytes) after the
transfer is completed.

Comment 7

[Kathleen :Brade]

I see the same thing as Chris; downloading goes along fine (averaging 94k/sec or
so) and then it hits 50.5Meg and zip... it's done.  The resulting file is the
same size and stuffit expander doesn't seem to want to expand it.

The problem is only for files over a large size which are *.hqx (other file
types are fine and smaller *.hqx files are fine).

N7 works fine; we should find out if PPEmbed has this problem or not.

Comment 8

[Kathleen :Brade]

Chris also sees the problem with this hqx file:
http://download.adobe.com/pub/adobe/golive/mac/6.x/GL6.0.1_Mac_Client_Updater.hqx
(only 8.1 meg)

Comment 9

[Chris Petersen]

This works properly in PPEmbed using both urls specified. Seems to be related to
file size and .hqx format.

Comment 10

[Simon Fraser [no longer active]]

Here's the deal with GL6.0.1_Mac_Client_Updater.hqx:
1. Clicking the link apparently gives an aborted download (at about 6Mb)
2. Context-click->Download link target saves it fine

If you look at the resulting files, in the first case, you actually get a .sit
file (with a .hqx extension). Fix the extension, and this file unstuffs just fine.

In the second case, you get a good .hqx file.

What I think is happening is that the server has been configured to un-Binhex on
the fly (like some servers gunzip .gz files), but that it still reports the
binhexed file size. Or, perhaps we're un-bihexing internally.

Comment 11

[Simon Fraser [no longer active]]

So we're actually unbinhexing internally here; we have a nsBinHexDecoders in the
steam converters directory.

So the issues are:
1. why does chinera un-binhdex, when the others don't
2. if we want to un-binhex, we need to set the new file name and type/creator
   info.

Comment 12

[Simon Fraser [no longer active]]

So I figured this out. The BinHex decoder should not be build for Mac builds;
it's intended only as a stop-gap for other platforms, and it's assumed on Mac
that helper apps will do the binhex decoding. I have a patch that fixes this
(and also addes a missing file for AppleSingle decoding to the build).

Comment 13

[Simon Fraser [no longer active]]

Attachment: Necko patch to turn off binhex

This patch removes nsBinHexDecoder from mac builds, adds nsAppleFileDecoder,
and fixes the resulting build issues in nsAppleFileDecoder.app.

Comment 14

[Simon Fraser [no longer active]]

cc: darin for necko module changes.

Comment 15

[Steve Dagley]

Comment on attachment 97115 [details] [diff] [review]
Necko patch to turn off binhex

r=sdagley (lose the changes to nsDiskCacheDevice.cpp)

Comment 16

[Darin Fisher]

Comment on attachment 97115 [details] [diff] [review]
Necko patch to turn off binhex

sr=darin (sans cache changes of course)

Comment 17

[Simon Fraser [no longer active]]

Checked into the Chimera branch. Will also check into the trunk.

Comment 18

[Chris Petersen]

Awesome. Verified in the 2002-08-29-05 NB.

Comment 19

[Simon Fraser [no longer active]]

This has now been checked into the Trunk (for Macho Mozilla builds).