1649294 - Make RemoteDecoder work with background taskqueue

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task)

Description

[Jean-Yves Avenard [:jya]]

Split from bug 1634846.

Current the RemoteDecoderParent/Child create a manager thread ; this was required as MessageChannel only worked with single thread or MessageLoop.

Once bug 1634846 is fixed; it's no longer required and we can use a background taskqueue reducing the number of threads use at any given time

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1649294 - Make RemoteDecoder use a background taskqueue. r?mattwoodrow

There's a small race that can happen when the remote decoder gets shutdown during xpcom shutdown; that would cause GetCurrentSerialEventTarget to return null. Leading to an assertion failure in ActorLifecycleProxy thread-safety check when PRemoteDecoderManagerParent gets destroyed.

So we use a background taskqueue instead and cleanup a bit the threading code in there allowed thanks to the TaskQueue ability to not require an explicit shutdown.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fda262d73a13
Make RemoteDecoder use a background taskqueue. r=mattwoodrow

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for webgl-conf crashes

Backout link: https://hg.mozilla.org/integration/autoland/rev/ed44d4e62140475b5daba4e7db38808dfea95960
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307988602&repo=autoland&lineNumber=3484

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c634db4960d3
Make RemoteDecoder use a background taskqueue. r=mattwoodrow,andi

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c634db4960d3