Reject DocumentLoadListener's Open promise as soon as we decide to switch process
Categories
(Core :: Networking, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
We currently defer rejecting the Open promise when we process switch, since we want to first notify the old process that the load has moved.
This is to prevent sub-frame process switches from accidentally marking the outer document as loaded.
Unfortunately, this causes extra complexity in DocumentLoadListener (we need to track the transitional state, where we're logically disconnected and can't be cancelled, without actually being disconnected).
I think we can just instead reject immediately, but let the consumers know that it's a process switch rejection, and they can handle it accordingly.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28298106459d Don't delay rejecting DocumentLoadListener's Open promise when we switch process. r=jya
|
||
Comment 3•4 years ago
|
||
Backed out changeset 28298106459d for causing multiple mochitest failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/b2a7680a1700007ffccee425097cfc8a199388a5
Failure logs:
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308264160&repo=autoland&lineNumber=4411
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308262561&repo=autoland&lineNumber=11100
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308264078&repo=autoland&lineNumber=3664
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308263194&repo=autoland&lineNumber=2618
|
||
Comment 4•4 years ago
|
||
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e349b00a1e4 Don't delay rejecting DocumentLoadListener's Open promise when we switch process. r=jya
|
||
Comment 6•4 years ago
•
|
||
Backed out changeset 3e349b00a1e4 (Bug 1649349) for causing failures in browser_CORS-console-warnings.js
Push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=3e349b00a1e41edf93cd8e64afd1654f79f531c5
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308292582&repo=autoland&lineNumber=19022
Backout: https://hg.mozilla.org/integration/autoland/rev/845a1f2beb8a46838ccae6da02358193d56bd24f
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f7c95cb5aac Don't delay rejecting DocumentLoadListener's Open promise when we switch process. r=jya
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•4 years ago
|
Description
•