1649477 - Leak involving in-process JSProcessActors

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

As Neil was adding a new JSProcessActor, they encountered a semi-reliable memory leak with the new in-process JSProcessActors introduced in bug 1633379.

This leak will only occur after introducing a new JSProcessActor with registered observer notifications.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1633379

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1649477 - Part 1: Move JSActor related files into their own directory,

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1649477 - Part 2: Unify JSActor manager logic,

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1649477 - Part 3: Handle ReceiveRawMessage generically,

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1649477 - Part 4: Improve a couple of error messages,

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8959d02b840f
Part 1: Move JSActor related files into their own directory, r=kmag
https://hg.mozilla.org/integration/autoland/rev/5b217aa88289
Part 2: Unify JSActor manager logic, r=kmag
https://hg.mozilla.org/integration/autoland/rev/eca6e9dce450
Part 3: Handle ReceiveRawMessage generically, r=kmag
https://hg.mozilla.org/integration/autoland/rev/830aa93d2b0c
Part 4: Improve a couple of error messages, r=kmag

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on JSActor.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/d890454d6684f92cf46e6acfd4661dce2ac51bd1
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308891452&repo=autoland&lineNumber=46394

Comment 8

[Kim Moir [:kmoir] ET]

nika: Triaging as reo is this bug for fission only use case or for the non fission use case as well?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ad359f8308b
Part 1: Move JSActor related files into their own directory, r=kmag
https://hg.mozilla.org/integration/autoland/rev/d3c935827ef7
Part 2: Unify JSActor manager logic, r=kmag
https://hg.mozilla.org/integration/autoland/rev/d7810f45f0cb
Part 3: Handle ReceiveRawMessage generically, r=kmag
https://hg.mozilla.org/integration/autoland/rev/5907260fa468
Part 4: Improve a couple of error messages, r=kmag

Comment 10

[Nika Layzell [:nika] (ni? for response)]

(In reply to Kim Moir [:kmoir] ET from comment #8)

nika: Triaging as reo is this bug for fission only use case or for the non fission use case as well?

This bug should have no impact right now, as there are no users of the leaky code, but it was discovered when we were trying to add a new user. It'll only impact newly written code.

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0ad359f8308b
https://hg.mozilla.org/mozilla-central/rev/d3c935827ef7
https://hg.mozilla.org/mozilla-central/rev/d7810f45f0cb
https://hg.mozilla.org/mozilla-central/rev/5907260fa468