1649577 - Make the Addressbook dialogs themeable

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

The Addressbok window is already themeable. What's missing are the dialogs opened in the Addressbook.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1649577-ab-card-themeable.patch

This adds the themeableDialog.css to all dialogs that opens through the addressbook.
I added to the buttons and menulists a border to more look like the system buttons. This will also make the buttons/menulists better differentiate from the backgrounds.

Many thanks to pmorris which provided me the script to load the stylesheet to the shadow-DOM to also apply the styles to the dialog buttons on bottom.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9160617 [details] [diff] [review]
1649577-ab-card-themeable.patch

Review of attachment 9160617 [details] [diff] [review]:
-----------------------------------------------------------------

Amazing work, thank you for taking care of these.

There's a small typo in the commit message on "Addreebook" .

Quick question, maybe not related to this bug, but would be possible to implement the Tab style we currently use int he prefs and account settings also for these dialogs?
The Tab style used in these dialog is very small and the bordered container wrapping the whole section doesn't look great.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1649577-ab-card-themeable.patch

(In reply to Alessandro Castellani (:aleca) from comment #2)

Comment on attachment 9160617 [details] [diff] [review]
1649577-ab-card-themeable.patch

Review of attachment 9160617 [details] [diff] [review]:

Amazing work, thank you for taking care of these.

There's a small typo in the commit message on "Addreebook" .

Fixed

Quick question, maybe not related to this bug, but would be possible to
implement the Tab style we currently use int he prefs and account settings
also for these dialogs?

Like this?

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9160951 [details] [diff] [review]
1649577-ab-card-themeable.patch

Review of attachment 9160951 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely, thank you.

Just a little nit CSS for the `tab + tab` styling coming from the `tabbox.css` file.
We need to overwrite that `magin-inline-start: -2px` otherwise a hovered tab effect overlaps by 2px another tab if the adjacent tab is currently active.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1649577-ab-card-themeable.patch

Fixed the tab spacing under Linux. I also changed the active tab line colour to use the same as the tabs in the main window.

[Approval Request Comment]
User impact if declined: less themed dialogs. This patch is also needed to style more dialogs later.
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): should be low.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/92a37c607699
Make the Addressbook dialogs themeable. r=aleca

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a485d13bfb52
follow-up - Fix linting and CSS errors. rs=linting

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1649577-ab-card-themeable-beta-ESR.patch

Patch with the linting fixes combined.

[Approval Request Comment]
User impact if declined: less themed dialogs. This patch is also needed to style more dialogs later.
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): should be low.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9161296 [details] [diff] [review]
1649577-ab-card-themeable-beta-ESR.patch

Approved for beta, when we build 79

Comment 10

[Geoff Lankow (:darktrojan)]

Thunderbird 79.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/207e6a4332f6

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9161296 [details] [diff] [review]
1649577-ab-card-themeable-beta-ESR.patch

Approved for esr78 - taking some risk here, will want to watch the beta feedback

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 78.0.1:
https://hg.mozilla.org/releases/comm-esr78/rev/d74534d733fb

Comment 13

[Wayne Mery (:wsmwk)]

I don't see any problems on Mac

Comment 14

[WaltS48 [:walts48]]

(In reply to Wayne Mery (:wsmwk) from comment #13)

I don't see any problems on Mac

Same here on Ubuntu 18.04 LTS.