1649593 - ExtensionParent.jsm imports OS.File during startup

Assignee

Description

•

4 years ago

According to this startup profile, ExtensionParent.jsm runs during startup and imports osfile.jsm. We should migrate this to the new IOUtils replacement for osfile.jsm when possible.

Stack:

(root) []
XREMain::XRE_main []
XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [libxul.so]
XREMain::XRE_mainRun() [libxul.so]
nsXREDirProvider::DoStartup() [libxul.so]
SharedStub [libxul.so]
PrepareAndDispatch [libxul.so]
XPCWrappedJS method call []
nsXPCWrappedJS::CallMethod(unsigned short, nsXPTMethodInfo const*, nsXPTCMiniVariant*) [libxul.so]
JS_CallFunctionValue(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::RunScript []
observe [resource://gre/modules/addonManager.js:84:9]
startup [resource://gre/modules/AddonManager.jsm:3461:9]
startup [resource://gre/modules/AddonManager.jsm:638:9]
_startProvider [resource://gre/modules/AddonManager.jsm:574:16]
callProvider [resource://gre/modules/AddonManager.jsm:206:21]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
js::fun_apply(JSContext*, unsigned int, JS::Value*) [libxul.so]
js::RunScript []
startup [resource://gre/modules/addons/XPIProvider.jsm:2424:9]
startup [resource://gre/modules/addons/XPIProvider.jsm:1918:15]
callBootstrapMethod [resource://gre/modules/addons/XPIProvider.jsm:1747:27]
loadBootstrapScope [resource://gre/modules/addons/XPIProvider.jsm:1849:20]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::NativeGetExistingProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<js::NativeObject*>, JS::Handle<js::Shape*>, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallGetter(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
mozilla::dom::module_getter::ModuleGetter(JSContext*, unsigned int, JS::Value*) [libxul.so]
mozJSComponentLoader::Import(JSContext*, nsTSubstring<char> const&, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSObject*>, bool) [libxul.so]
component loader load module []
mozJSComponentLoader::ObjectForLocation(ComponentLoaderInfo&, nsIFile*, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSScript*>, char**, bool, JS::MutableHandle<JS::Value>) [libxul.so]
js::ExecuteInJSMEnvironment(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>) [libxul.so]
js::ExecuteInJSMEnvironment(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>, JS::Handle<JS::StackGCVector<JSObject*, js::TempAllocPolicy> >) [libxul.so]
ExecuteInExtensibleLexicalEnvironment(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>) [libxul.so]
js::RunScript []
resource://gre/modules/Extension.jsm []
js::ExecuteKernel(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>, JS::Handle<JS::Value>, js::AbstractFramePtr, JS::MutableHandle<JS::Value>) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
ChromeUtils.import []
mozilla::dom::ChromeUtils_Binding::import(JSContext*, unsigned int, JS::Value*) [libxul.so]
ChromeUtils::Import resource://gre/modules/ExtensionParent.jsm []
mozilla::dom::ChromeUtils::Import(mozilla::dom::GlobalObject const&, nsTSubstring<char16_t> const&, mozilla::dom::Optional<JS::Handle<JSObject*> > const&, JS::MutableHandle<JSObject*>, mozilla::ErrorResult&) [libxul.so]
mozJSComponentLoader::Import(JSContext*, nsTSubstring<char> const&, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSObject*>, bool) [libxul.so]
component loader load module []
mozJSComponentLoader::ObjectForLocation(ComponentLoaderInfo&, nsIFile*, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSScript*>, char**, bool, JS::MutableHandle<JS::Value>) [libxul.so]
js::ExecuteInJSMEnvironment(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>) [libxul.so]
js::ExecuteInJSMEnvironment(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>, JS::Handle<JS::StackGCVector<JSObject*, js::TempAllocPolicy> >) [libxul.so]
ExecuteInExtensibleLexicalEnvironment(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>) [libxul.so]
js::RunScript []
> resource://gre/modules/ExtensionParent.jsm []
js::ExecuteKernel(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>, JS::Handle<JS::Value>, js::AbstractFramePtr, JS::MutableHandle<JS::Value>) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::NativeGetExistingProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<js::NativeObject*>, JS::Handle<js::Shape*>, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallGetter(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
mozilla::dom::module_getter::ModuleGetter(JSContext*, unsigned int, JS::Value*) [libxul.so]
mozJSComponentLoader::Import(JSContext*, nsTSubstring<char> const&, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSObject*>, bool) [libxul.so]
profiler_get_backtrace() [libxul.so]
Registers::SyncPopulate() [libxul.so]

Keefer Rourke

Comment 1

•

3 years ago

Attached file Bug 1649593: Use IOUtils instead of OS.File in ExtensionParent.jsm r?barret,zombie — Details

Depends on D87020

Phabricator Automation

Updated

•

3 years ago

Assignee: nobody → krourke

Status: NEW → ASSIGNED

Phabricator Automation

Updated

•

3 years ago

Attachment #9170760 - Attachment description: Bug 1649593: Use IOUtils instead of OS.File in ExtensionParent.jsm r?barret → Bug 1649593: Use IOUtils instead of OS.File in ExtensionParent.jsm r?barret,zombie

Pulsebot

Comment 2

•

3 years ago

Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8aca41723313
Use IOUtils instead of OS.File in ExtensionParent.jsm r=barret,zombie

Razvan Maries

Comment 3

•

3 years ago

Backed out for perma failures. See https://bugzilla.mozilla.org/show_bug.cgi?id=1660328#c5

Pulsebot

Comment 4

•

3 years ago

Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75df9f571169
Use IOUtils instead of OS.File in ExtensionParent.jsm r=barret,zombie

Noemi Erli[:noemi_erli]

Comment 5

•

3 years ago

Backed out 3 changesets (Bug 1649595, Bug 1649596, Bug 1649593) for causing failures in ExtensionParent.jsm

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=SXYl3CyzSnKtISIX2nnK8A.0&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt%2Cxpcshell%2Ctests%2Ctest-linux1804-64-tsan%2Fopt-xpcshell-e10s%2Cx3&revision=ff93a88d2de232038327da95b143cf6b89ee8d69

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314443126&repo=autoland&lineNumber=3246

Backout: https://hg.mozilla.org/integration/autoland/rev/0b58d4793d6be1bcace9022cae96a9741db6e926

Flags: needinfo?(mail)

Barret Rennie [:barret] (they/them)

Assignee

Comment 6

•

3 years ago

I'm taking these bugs over from :krourke since his internship is over.

Assignee: mail → brennie

Flags: needinfo?(mail)

Barret Rennie [:barret] (they/them)

Assignee

Updated

•

3 years ago

Depends on: 1665171

Emma Malysz

Comment 7

•

3 years ago

This also looks like it uses OS.Path.join, so we'll need to remove that as well https://searchfox.org/mozilla-central/rev/803b368879fa332e8e2c1840bf1ec164f7ed2c32/toolkit/components/extensions/ExtensionParent.jsm#1718

Emma Malysz

Updated

•

3 years ago

Depends on: 1671035

Luca Greco [:rpl] [:luca] [:lgreco]

Updated

•

3 years ago

Blocks: 1522925

Barret Rennie [:barret] (they/them)

Assignee

Updated

•

3 years ago

Depends on: 1672431

Pulsebot

Comment 8

•

3 years ago

Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90ff1773203a
Use IOUtils instead of OS.File in ExtensionParent.jsm r=zombie,rpl

Atila Butkovits

Comment 9

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/90ff1773203a

Status: ASSIGNED → RESOLVED

Closed: 3 years ago

status-firefox89: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 89 Branch

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Updated

•

3 years ago

Regressions: 1700656

Mark Banner (:standard8)

Updated

•

3 years ago

Regressions: 1701161

Alexandru Michis [:malexandru]

Updated

•

3 years ago

Regressions: 1700853

Luca Greco [:rpl] [:luca] [:lgreco]

Updated

•

3 years ago

Updated

•

3 years ago

Regressions: 1709687

Shane Caraveo (:mixedpuppy)

Updated

•

3 years ago

Updated

•

7 months ago

Product: Toolkit → Toolkit Graveyard

Bugzilla

Quick Search

ExtensionParent.jsm imports OS.File during startup

Categories

(Toolkit Graveyard :: OS.File, task)

Tracking

(firefox89 fixed)

People

(Reporter: barret, Assigned: barret)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Updated

Updated

Comment 2

Comment 3

Comment 4

Comment 5

Comment 6

Updated

Comment 7

Updated

Updated

Updated

Comment 8

Comment 9

Updated

Updated

Updated

Updated

Updated

Updated

Updated