1649604 - JSONFile.jsm imports OS.File during startup

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task)

Description

[Barret Rennie [:barret] (they/them)]

According to this startup profile, JSONFile.jsm runs during startup and imports osfile.jsm. We should migrate this to the new IOUtils replacement for osfile.jsm when possible.

Stack:

(root) []
XREMain::XRE_main []
XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [libxul.so]
XREMain::XRE_mainRun() [libxul.so]
nsAppStartup::Run() [libxul.so]
nsBaseAppShell::Run() [libxul.so]
MessageLoop::Run() [libxul.so]
mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [libxul.so]
nsThread::ProcessNextEvent(bool, bool*) [libxul.so]
mozilla::CycleCollectedJSContext::AfterProcessTask(unsigned int) [libxul.so]
promise callback []
mozilla::PromiseJobRunnable::Run(mozilla::AutoSlowOperation&) [libxul.so]
mozilla::dom::PromiseJobCallback::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::ErrorResult&) [libxul.so]
JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
PromiseReactionJob(JSContext*, unsigned int, JS::Value*) [libxul.so]
AsyncFunctionResume(JSContext*, JS::Handle<js::AsyncFunctionGeneratorObject*>, ResumeKind, JS::Handle<JS::Value>) [libxul.so]
js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [libxul.so]
js::RunScript []
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
AsyncFunctionNext [self-hosted:688:26]
asyncEmitManifestEntry [resource://gre/modules/ExtensionCommon.jsm:1542:30]
0xff4eaa5dbc7 []
js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICCall_Fallback*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) [libxul.so]
js::RunScript []
onManifestEntry [chrome://browser/content/parent/ext-commands.js:20:23]
loadCommands [resource://gre/modules/ExtensionShortcuts.jsm:165:14]
loadCommands/this.commands< [resource://gre/modules/ExtensionShortcuts.jsm:171:27]
loadCommandsFromStorage [resource://gre/modules/ExtensionShortcuts.jsm:256:31]
initialize [resource://gre/modules/ExtensionSettingsStore.jsm:319:12]
initialize [resource://gre/modules/ExtensionSettingsStore.jsm:98:19]
> load [resource://gre/modules/JSONFile.jsm:195:12]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::NativeGetExistingProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<js::NativeObject*>, JS::Handle<js::Shape*>, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallGetter(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
mozilla::dom::module_getter::ModuleGetter(JSContext*, unsigned int, JS::Value*) [libxul.so]
mozJSComponentLoader::Import(JSContext*, nsTSubstring<char> const&, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSObject*>, bool) [libxul.so]
profiler_get_backtrace() [libxul.so]
Registers::SyncPopulate() [libxul.so]

Comment 1

[Emma Malysz]

Attachment: Bug 1649604, remove OS.File usage from JSONFile.jsm

Comment 2

[Emma Malysz]

Attachment: Bug 1649604, remove OS.File usage from JSONFile.jsm

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db75491e5d2e
remove OS.File usage from JSONFile.jsm r=Gijs

Comment 4

[Atila Butkovits]

Backed out for causing xpcshell and marionette failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a5e436040f26431caabe563e23672c7a605c1f5e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=YYCB-R-rQPSto2pmWMXkGg.0&revision=db75491e5d2eb754452146cffe297f0d77033052&searchStr=marionette

Failure log: https://treeherder.mozilla.org/logviewer?job_id=327706255&repo=autoland&lineNumber=62139
https://treeherder.mozilla.org/logviewer?job_id=327704899&repo=autoland&lineNumber=3748
https://treeherder.mozilla.org/logviewer?job_id=327706972&repo=autoland&lineNumber=2336

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emalysz, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[:Gijs (he/him)]

This hadn't landed because of bug 1672431, which landed and stuck 4 hours ago, so we should be able to land this now, I think, Emma?

Comment 7

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #6)

This hadn't landed because of bug 1672431, which landed and stuck 4 hours ago, so we should be able to land this now, I think, Emma?

D'oh, cleared the wrong needinfo.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/065644a4b755
remove OS.File usage from JSONFile.jsm r=Gijs

Comment 9

[Atila Butkovits]

Backed out for causing failure on test_update_theme.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/fe4b842cb23c9c1fce56e5457b3c16717eeff091

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&revision=065644a4b75524d51a17401c79d4537bf5061f72&searchStr=Linux%2C18.04%2Cx64%2CWebRender%2Cdebug%2CXpcshell%2Ctests%2Ctest-linux1804-64-qr%2Fdebug-xpcshell-e10s%2CX2&selectedTaskRun=VhJ9Pp-RR5eWzxoNo7mFFA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=334175448&repo=autoland&lineNumber=2559

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bac3906ff3ff
remove OS.File usage from JSONFile.jsm r=Gijs

Comment 11

[Atila Butkovits]

Backed out for causing Xpcshell failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/12e64cff7f81280003506ee280ea38a03e9c5745

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=DCFpN6o9Rle8hxWQQqdqZw.0&revision=bac3906ff3fff16349c5253636f87e9e4877839e&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Cxpcshell%2Ctests%2Ctest-linux1804-64-asan%2Fopt-xpcshell-e10s%2Cx2

Failure log: https://treeherder.mozilla.org/logviewer?job_id=337472307&repo=autoland&lineNumber=2440
https://treeherder.mozilla.org/logviewer?job_id=337467812&repo=autoland&lineNumber=3058

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f76a69e26f9
remove OS.File usage from JSONFile.jsm r=Gijs

Comment 13

[Dorel Luca [:dluca]]

Backed out changeset 4f76a69e26f9 (bug 1649604) for XPCshell failures in xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_strictcompatibility.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=338203184&repo=autoland&lineNumber=3275

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=4f76a69e26f93dc93a2cceca33e969b4eb6f77a5

Backout:
https://hg.mozilla.org/integration/autoland/rev/28e04a08d2e42d3579b28b36becda67d945d6abe

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acba61a1c652
remove OS.File usage from JSONFile.jsm r=Gijs,robwu

Comment 15

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/acba61a1c652