1649613 - Sqlite.jsm imports OS.File during startup

Status: RESOLVED FIXED

(Toolkit :: OS.File, task)

Description

[Barret Rennie [:barret] (they/them)]

According to this startup profile, Sqlite.jsm runs during startup and imports osfile.jsm. We should migrate this to the new IOUtils replacement for osfile.jsm when possible.

Stack:

(root) []
XREMain::XRE_main []
XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [libxul.so]
XREMain::XRE_mainRun() [libxul.so]
nsAppStartup::Run() [libxul.so]
nsBaseAppShell::Run() [libxul.so]
MessageLoop::Run() [libxul.so]
mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [libxul.so]
nsThread::ProcessNextEvent(bool, bool*) [libxul.so]
mozilla::CycleCollectedJSContext::AfterProcessTask(unsigned int) [libxul.so]
promise callback []
mozilla::PromiseJobRunnable::Run(mozilla::AutoSlowOperation&) [libxul.so]
mozilla::dom::PromiseJobCallback::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::ErrorResult&) [libxul.so]
JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
PromiseReactionJob(JSContext*, unsigned int, JS::Value*) [libxul.so]
js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [libxul.so]
js::RunScript []
DownloadsDataCtor/this._promiseList< [resource:///modules/DownloadsCommon.jsm:772:56]
getList [resource://gre/modules/DownloadHistory.jsm:71:15]
ensureInitialized [resource://gre/modules/DownloadHistory.jsm:189:19]
ensureInitialized/this._initializePromise< [resource://gre/modules/DownloadHistory.jsm:193:37]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
bound [self-hosted:839:25]
0xff4eaa5bed3 []
js::jit::InvokeFromInterpreterStub(JSContext*, js::jit::InterpreterStubExitFrameLayout*) [libxul.so]
js::RunScript []
fetchAnnotatedPages [resource://gre/modules/History.jsm:200:21]
promiseDBConnection [resource://gre/modules/PlacesUtils.jsm:1471:23]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::NativeGetExistingProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<js::NativeObject*>, JS::Handle<js::Shape*>, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallGetter(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::MutableHandle<JS::Value>) [libxul.so]
js::RunScript []
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
get [resource://gre/modules/XPCOMUtils.jsm:124:20]
0xff4eaa5dbc7 []
js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICCall_Fallback*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
js::fun_apply(JSContext*, unsigned int, JS::Value*) [libxul.so]
js::fun_call(JSContext*, unsigned int, JS::Value*) [libxul.so]
js::RunScript []
(root scope) resource://gre/modules/PlacesUtils.jsm [resource://gre/modules/PlacesUtils.jsm:2045:58]
> cloneStorageConnection [resource://gre/modules/Sqlite.jsm:1151:31]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::NativeGetExistingProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<js::NativeObject*>, JS::Handle<js::Shape*>, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallGetter(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
mozilla::dom::module_getter::ModuleGetter(JSContext*, unsigned int, JS::Value*) [libxul.so]
mozJSComponentLoader::Import(JSContext*, nsTSubstring<char> const&, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSObject*>, bool) [libxul.so]
profiler_get_backtrace() [libxul.so]
Registers::SyncPopulate() [libxul.so]

Comment 1

[Michelle Goossens]

Attachment: Bug 1649613 - Convert Sqlite.jsm to use PathUtils r=emalysz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3893eeb0540
Convert Sqlite.jsm to use PathUtils r=emalysz

Comment 3

[Atila Butkovits]

Backed out for causing Bug 1683046.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a28783ad808e072df614376204adf05e052b2be4

Failure log: https://treeherder.mozilla.org/logviewer?job_id=324787739&repo=autoland&lineNumber=2901
https://treeherder.mozilla.org/logviewer?job_id=324787733&repo=autoland&lineNumber=3182
https://treeherder.mozilla.org/logviewer?job_id=324787794&repo=autoland&lineNumber=2627

Comment 4

[Michelle Goossens]

This patch depends on 1682031 which got backed out, most likely causing this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5a6f093e336
Convert Sqlite.jsm to use PathUtils r=emalysz

Comment 6

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=e39ed11389760d37a501a94d0fe1026fe884ab1b&searchStr=xpcshell&failure_classification_id=2

Logs:
https://treeherder.mozilla.org/logviewer?job_id=325102439&repo=autoland&lineNumber=5313
https://treeherder.mozilla.org/logviewer?job_id=325101777&repo=autoland&lineNumber=5542
https://treeherder.mozilla.org/logviewer?job_id=325102772&repo=autoland&lineNumber=7234

Backout: https://hg.mozilla.org/integration/autoland/rev/8d8d3ecf368ff94d44fe2a0bd07a2729b50c4cf8

Comment 7

[Michelle Goossens]

Oops, for some reason I failed to include a specific case here (this specific case causes the path to be incorrect.), running a try push now with a fix.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/079a3bda7172
Convert Sqlite.jsm to use PathUtils r=emalysz

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/079a3bda7172

Comment 10

[Razvan Maries]

Backed out for causing bug 1554453.

Backout: https://hg.mozilla.org/integration/autoland/rev/33696c955659b898db9f7e98c0acee9d181e84fc

Comment 11

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/33696c955659

Comment 12

[Michelle Goossens]

Going to see what the updated patch does on try: https://treeherder.mozilla.org/jobs?repo=try&revision=c149dfc835e6fb82afc2973b328a6608c3c90e1a

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/468b7aacbf35
Convert Sqlite.jsm to use PathUtils r=emalysz

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/468b7aacbf35