Closed Bug 1649850 Opened 1 year ago Closed 1 year ago

Refactor minimum Rust version for bootstrap and configure into a common place

Categories

(Firefox Build System :: General, enhancement, P3)

enhancement

Tracking

(firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: froydnj, Assigned: rstewart)

Details

(Keywords: in-triage)

Attachments

(1 file)

That way we won't have to worry about bug 1649039 popping up again.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: General → Bootstrap Configuration
Component: Bootstrap Configuration → General

Can we just reduce code duplication by putting the minimum Rust version in some common place? configure and bootstrap can both import it. Seems just as foolproof and easier to do than setting up a separate lint.

(In reply to Ricky Stewart from comment #2)

Can we just reduce code duplication by putting the minimum Rust version in some common place? configure and bootstrap can both import it. Seems just as foolproof and easier to do than setting up a separate lint.

I think if we can do that and either a) still have the single-file bootstrap.py script work or b) remove the single-file bootstrap.py script first, that would be preferable to a lint. We do manage to make something like this work for Android, so it ought to work for Rust as well.

Severity: -- → S3
Keywords: in-triage
Priority: -- → P3
Assignee: nobody → rstewart

Lint seems overkill.

The lack of duplication should prevent bugs like bug 1649039 popping up again.

Summary: add a lint for consistency between configure's required rust version and bootstrap's installed version → Refactor minimum Rust version for bootstrap and configure into a common place
Pushed by rstewart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6367a90c7cc3
Refactor minimum Rust version into a common place for `bootstrap` and `configure` r=nalexander
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.