1649893 - [wpt-sync] Sync PR 24418 - Fix CSS typed OM CSSSkewX and CSSSkewY toMatrix method to use degrees instead of radians.

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24418 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24418
Details from upstream follow.

Chany Arpin-Plante <[e-mail]> wrote:

Fix CSS typed OM CSSSkewX and CSSSkewY toMatrix method to use degrees instead of radians.

The toMatrix method of a CSSTransformComponent should return a DOMMatrix
representing the object transformation.
https://www.w3.org/TR/css-typed-om-1/#dom-csstransformcomponent-tomatrix

The skewXSelf and skewYSelf methods used to apply a transformation on a
matrix must be provided with an angle parameter expressed in degrees.
https://www.w3.org/TR/geometry-1/#dom-dommatrix-skewxself
https://www.w3.org/TR/geometry-1/#dom-dommatrix-skewyself

Since the angles passed to the skewXSelf and skewYSelf were in radians,
DOMMatrix returned by the toMatrix method of those two components was incorrect.

R=[e-mail]

Change-Id: I5edc1cdf1493184584154723508c6e20c212ac92
Reviewed-on: https://chromium-review.googlesource.com/2242008
WPT-Export-Revision: 96ddbade826f5d61c77dc3dc649e9c46d3fc51f7

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b65b47fa5cc495c52431a264918be2444065dec

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
FAIL: 8

Chrome

OK : 1
PASS: 6
FAIL: 2

Safari

OK : 1
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-toMatrix.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
CSSSkew.toMatrix() returns correct matrix: FAIL (Chrome: PASS, Safari: FAIL)
CSSScale.toMatrix() returns correct matrix: FAIL (Chrome: PASS, Safari: FAIL)
CSSMatrixComponent.toMatrix() returns correct matrix: FAIL (Chrome: PASS, Safari: FAIL)
CSSPerspective.toMatrix() returns correct matrix: FAIL (Chrome: PASS, Safari: FAIL)
CSSRotate.toMatrix() returns correct matrix: FAIL (Chrome: PASS, Safari: FAIL)
CSSSkewY.toMatrix() returns correct matrix: FAIL (Chrome: FAIL, Safari: FAIL)
CSSSkewX.toMatrix() returns correct matrix: FAIL (Chrome: FAIL, Safari: FAIL)
CSSTranslate.toMatrix() returns correct matrix: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-toMatrix.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ca2fd30f587
[wpt PR 24418] - Fix CSS typed OM CSSSkewX and CSSSkewY toMatrix method to use degrees instead of radians., a=testonly

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5ca2fd30f587