1650030 - Pawn move sound on lichess.org not playing after the first move

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Dennis Schubert [:denschub]]

STR:

1. Open https://lichess.org/
2. Click "Play with the computer"
3. Pick the white side
4. Make the first move, observe the "chime" sound
5. Wait for the computer to make its move
6. Make another move yourself

Expected:

Steps 5 and 6 should play a "pawn move" sound effect.

Actual:

No sound to be heard.

Note: This is a regression from bug 1618225.

Comment 1

[Dennis Schubert [:denschub]]

:carnould, since you wrote the patches in bug 1618225, your input would be appreciated.

Comment 2

[carnould]

Working on a fix, it should be out soon, with a test

Comment 3

[carnould]

Attachment: Bug 1650030 - Improve the condition that forces to set STOP. r?padenot

Comment 4

[carnould]

Attachment: Bug 1650030 - Revert changes for bug 1618225. r?padenot

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f4ce44b07cc
Revert changes for bug 1618225. r=padenot

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 7

[carnould]

Comment on attachment 9161264 [details]
Bug 1650030 - Revert changes for bug 1618225. r?padenot

Beta/Release Uplift Approval Request

• User impact if declined: Short sounds won't be played correctly if some parameters are set. It's a backout from https://phabricator.services.mozilla.com/D79873
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is not risky, it will fix this bug and make a small regression on the bug the patch was made for
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9161264 [details]
Bug 1650030 - Revert changes for bug 1618225. r?padenot

backout a recent change for regression, approved for 79.0b4

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e621b9981d60

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5f4ce44b07cc

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24537 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot