Closed
Bug 1650117
Opened 5 years ago
Closed 5 years ago
Focused AB context menu button in Contacts Sidebar cannot be pressed with keyboard
Categories
(Thunderbird :: Message Compose Window, defect)
Thunderbird
Message Compose Window
Tracking
(thunderbird_esr78 fixed)
RESOLVED
FIXED
Thunderbird 80.0
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | fixed |
People
(Reporter: thomas8, Assigned: thomas8)
Details
(Whiteboard: [TM:78.1.1])
Attachments
(1 file, 1 obsolete file)
|
2.39 KB,
patch
|
thomas8
:
review+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
Whilst we now allow the AB context menu button (≡) in Contacts Side Bar to be focused (which makes sense), there's nothing users can do with that focus. Pressing Enter or spacebar on the button does nothing, only clicking works.
|
Assignee | |
Comment 1•5 years ago
|
||
5-minutes-review ;-)
Simple fix, and normalize distribution between layout layer and code layer.
Attachment #9160958 -
Flags: review?(alessandro)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9160958 [details] [diff] [review]
1650117_abContextMenuButton.diff
Review of attachment 9160958 [details] [diff] [review]:
-----------------------------------------------------------------
Lovely, thank you so much
::: mail/components/addrbook/content/abContactsPanel.js
@@ +23,5 @@
> + event.target,
> + "after_end",
> + 0,
> + 0,
> + true
linting nit, add comma after the last attribute.
Attachment #9160958 -
Flags: review?(alessandro) → review+
|
|
Assignee | |
Comment 3•5 years ago
|
||
trailing comma after last member of array added
Attachment #9160958 -
Attachment is obsolete: true
Attachment #9161104 -
Flags: review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed-tb
|
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 80.0
Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/ad0edca25dcc
Fix keyboard access to abContextMenuButton in Contacts Sidebar. r=aleca
|
|
Assignee | |
Comment 6•5 years ago
|
||
Comment on attachment 9161104 [details] [diff] [review]
1650117_abContextMenuButton.diff
[Approval Request Comment]
Regression caused by (bug #): not a regression
User impact if declined: AB context menu button not keyboard accessible
Testing completed (on c-c, etc.): yes, on C-C
Risk to taking this patch (and alternatives if risky): near zero (mini patch which changed onclick to oncommand)
Attachment #9161104 -
Flags: approval-comm-esr78?
|
||
Comment 8•5 years ago
|
||
Comment on attachment 9161104 [details] [diff] [review]
1650117_abContextMenuButton.diff
[Triage Comment]
Approved for esr78
Attachment #9161104 -
Flags: approval-comm-esr78? → approval-comm-esr78+
|
||
Comment 9•5 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•