Open Bug 1650244 Opened 6 years ago Updated 6 years ago

[wpt-sync] Sync PR 24428 - Use promise_test in idlharness

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24428 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24428
Details from upstream follow.

Mattias Buelens <mattias@buelens.com> wrote:

Use promise_test in idlharness

In #24363, we ran into a bug where a rejected promise was not correctly caught by the IDL harness. We fixed it by adding a .step_func() call, but it still feels weird having to manually add these.

This PR refactors all usages of async_test to promise_test in the IDL harness, leveraging async/await to easily chain promises within the tests. We no longer need any manual calls to a_test.step() or a_test.done(), since promise_test handles all of that for us. 😁

PR 24428 applied with additional changes from upstream: 6c7192b5706688f0c721ee5ad1f4c17f59a32300
You need to log in before you can comment on or make changes to this bug.