Closed Bug 1650257 Opened 3 months ago Closed 25 days ago

Crash in [@ IPCError-browser | RecvNewWindowGlobal Cannot create for missing BrowsingContext]

Categories

(Core :: DOM: Content Processes, defect, P2)

Unspecified
All
defect

Tracking

()

RESOLVED FIXED
82 Branch
Fission Milestone M6b
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox78 --- unaffected
firefox79 --- wontfix
firefox80 --- wontfix
firefox81 --- wontfix
firefox82 --- fixed

People

(Reporter: mccr8, Assigned: kmag)

References

(Regressed 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(8 files)

This bug is for crash report bp-d3957426-22ef-47dc-8c4e-ec20d0200702.

Top 10 frames of crashing thread:

0 ntdll.dll NtWaitForKeyedEvent 
1 ntdll.dll RtlSleepConditionVariableSRW 
2 kernel32.dll SleepConditionVariableSRW 
3 mozglue.dll mozilla::detail::ConditionVariableImpl::wait mozglue/misc/ConditionVariable_windows.cpp:50
4 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1150
5 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:504
6 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:109
7 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:309
8 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:291
9 xul.dll nsBaseAppShell::Run widget/nsBaseAppShell.cpp:137

Nika suspects this spiked after enabling BrowsingContext preservation for non-Fission users.

76% of these crashes are from Fenix. Are they using GeckoView 80.0a1 or 79.0b? Will we need to uplift a fix to 79 Beta?

Severity: -- → S2
Flags: needinfo?(nika)
OS: Windows 7 → All
Priority: -- → P2

Assigning this urgent crash to kmag and tracking for Fission M6a.

Assignee: nobody → kmaglione+bmo
Fission Milestone: --- → M6a
Flags: needinfo?(nika)
Keywords: leave-open
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4e5a70ce9b35
Assert we don't create window globals for discarded BCs. r=nika
Status: NEW → ASSIGNED
Whiteboard: [7/23]: waiting for new crash reports

I don't see any of these new release asserts, for what it is worth.

The original "IPCError-browser | RecvNewWindowGlobal" crash signature's volume seems to be unchanged (about 10-ish Firefox desktop crashes/day and 30-ish Fenix crashes/day). Why is Fenix crashing so much more than desktop?

https://crash-stats.mozilla.org/signature/?signature=IPCError-browser%20%7C%20RecvNewWindowGlobal%20Cannot%20create%20for%20missing%20BrowsingContext&date=%3E%3D2020-06-27T23%3A24%3A00.000Z&date=%3C2020-07-27T23%3A24%3A00.000Z#graphs

The new asserts have not shown up, so this needs some more investigation.

Fission Milestone: M6a → M6b
Attached file bug1650257-request.md
Attachment #9168292 - Flags: data-review?(chutten)
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4110afa01ff5
Add more diagnostic assertions. r=nika

Comment on attachment 9168292 [details]
bug1650257-request.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire as soon as the crash is resolved.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :kmag is responsible for removing the collection once the crash is resolved.


Result: datareview+

Attachment #9168292 - Flags: data-review?(chutten) → data-review+
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/02df440ae00f
Add crash annotations for "missing BrowsingContext" crashes. r=nika

(In reply to Chris Peterson [:cpeterson] from comment #1)

Nika suspects this spiked after enabling BrowsingContext preservation for non-Fission users.

kmag says we no longer suspect this crash is related to BrowsingContext Preservation.

No longer blocks: 1650979, 1658609
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/59c452963bf0
Also set NewWindowBCIsTop annotation in parent. r=nika
See Also: → 1658609
Keywords: leave-open
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0e93af0e9f9b
Part 1 - Stop discarding BCs from the parent on WindowGlobal destruction. r=nika
https://hg.mozilla.org/integration/autoland/rev/170177a44259
Part 2 - Abort SetNewDocument() if ancestors are discarded/cached. r=nika,smaug,sg
https://hg.mozilla.org/integration/autoland/rev/fc8cb8a279e8
Part 3 - Remove obsolete diagnostic crash annotations and assertions. r=nika
Whiteboard: [7/23]: waiting for new crash reports
You need to log in before you can comment on or make changes to this bug.