Closed Bug 1650277 Opened 4 years ago Closed 4 years ago

Stop using google's base::Thread with the MediaManager

Categories

(Core :: WebRTC: Audio/Video, defect, P2)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Bug 1650277 - P1. Let CubebDeviceEnumerator worry about MTA requirements. r?kinetik
47 bytes, text/x-phabricator-request
Details | Review
Bug 1650277 - P2. Ensure the CubebDeviceEnumerator is shutdown after the MTAThread. r?kinetik
47 bytes, text/x-phabricator-request
Details | Review
Bug 1650277 - P3. Use a media taskqueue with the MediaManager. r?jib
47 bytes, text/x-phabricator-request
Details | Review

The MediaManager uses a MessageLoop and a Google's thread; not sure why this was ever done that way.

It should be moved to using a background taskqueue.

Assignee: nobody → jyavenard

Ths helps not having to worry about how to create the thread; which could be probablematic when running off a thread pool.

On Windows the CubebDeviceEnumerator needs to run on an MTA thread; to achieve that goal we use the EnsureMTA utility.
EnsureMTA relies on a MTA thread to exist which will be destroyed when XPCOM shuts down ; as such we must shutdown the CubebDeviceEnumerator during the same shutdown phase.

ClearOnShutdown registrars are processed in LIFO order, so as the CubebDeviceEnumerator constructor uses EnsureMTA we are guaranteed that the CubebDeviceEnumerator clearOnShutdown will be processed before the EnsureMTA thread shutdown.
The CubebDeviceEnumerator needs to be shutdown before cubeb; which is also guaranteed as the cubeb instance is destroyed during the final XPCOM shutdown stage.

Fix GetSafety() thread-safety.

CubebDeviceEnumerator should be a static non-refcounted singleton on the stack really which would made the code much simpler, unfortunately its gtests rely on having the Shutdown method present to force re-scanning the devices and work with the mock cubeb.

Depends on D82142

Rename PostTask methods into Dispatch to be more in-line with the current naming convention as PostTask pretty much always referred to the MessageLoop's method.

Depends on D82158

See Also: → 1650352

Until bug 1650352 is fixed; can't use the MediaManager with a background thread pool; it needs to use more than one thread. So let's use a TaskQueue with a MediaThreadPool instead.

Attachment #9161190 - Attachment description: Bug 1650277 - P3. Use a background taskqueue with the MediaManager. r?jib → Bug 1650277 - P3. Use a taskqueue with the MediaManager. r?jib
See Also: → 1650728
Attachment #9161190 - Attachment description: Bug 1650277 - P3. Use a taskqueue with the MediaManager. r?jib → Bug 1650277 - P3. Use a background taskqueue with the MediaManager. r?jib
Severity: -- → S3
Priority: -- → P2
See Also: → 1651249
Attachment #9161190 - Attachment description: Bug 1650277 - P3. Use a background taskqueue with the MediaManager. r?jib → Bug 1650277 - P3. Use a media taskqueue with the MediaManager. r?jib
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11aa7071f858
P1. Let CubebDeviceEnumerator worry about MTA requirements. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/1bf131a86868
P2. Ensure the CubebDeviceEnumerator is shutdown after the MTAThread. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/07863e9844f0
P3. Use a media taskqueue with the MediaManager. r=jib

Backed out 3 changesets (bug 1650277) for RunWatchdog crashes.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunning%2Cpending%2Crunnable&fromchange=07863e9844f09003aff19861b04fc15c93c3275f&tochange=35ebecc3af12e2fc726f3ccc7218d45fb459d7f5&searchStr=mochitest&selectedTaskRun=PlCbXq33TzWpr5LTQZ59Ww.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/5e0c57ee6d1a558286e8d34dcd86078c0964f3cf

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308944520&repo=autoland&lineNumber=3897

[task 2020-07-08T07:59:20.959Z] 07:59:20     INFO - TEST-START | dom/media/test/test_streams_individual_pause.html
[task 2020-07-08T07:59:23.120Z] 07:59:23     INFO - GECKO(4734) | MEMORY STAT | vsize 20975028MB | residentFast 1037MB
[task 2020-07-08T07:59:23.129Z] 07:59:23     INFO - TEST-OK | dom/media/test/test_streams_individual_pause.html | took 2176ms
[task 2020-07-08T07:59:23.198Z] 07:59:23     INFO - TEST-START | Shutdown
[task 2020-07-08T07:59:23.199Z] 07:59:23     INFO - Passed:  2314
[task 2020-07-08T07:59:23.200Z] 07:59:23     INFO - Failed:  0
[task 2020-07-08T07:59:23.200Z] 07:59:23     INFO - Todo:    3
[task 2020-07-08T07:59:23.200Z] 07:59:23     INFO - Mode:    e10s
[task 2020-07-08T07:59:23.200Z] 07:59:23     INFO - Slowest: 49596ms - /tests/dom/media/test/test_eme_playback.html
[task 2020-07-08T07:59:23.201Z] 07:59:23     INFO - SimpleTest FINISHED
[task 2020-07-08T07:59:23.202Z] 07:59:23     INFO - TEST-INFO | Ran 1 Loops
[task 2020-07-08T07:59:23.204Z] 07:59:23     INFO - SimpleTest FINISHED
[task 2020-07-08T07:59:23.654Z] 07:59:23     INFO - GECKO(4734) | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-07-08T07:59:23.690Z] 07:59:23     INFO - GECKO(4734) | SharedThreadPool in xpcom-shutdown-threads. Waiting for pools "MediaPlayback"
[task 2020-07-08T07:59:23.746Z] 07:59:23     INFO - GECKO(4734) | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-07-08T07:59:23.747Z] 07:59:23     INFO - GECKO(4734) | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-07-08T07:59:24.680Z] 07:59:24     INFO - GECKO(4734) | 1594195164674	Marionette	TRACE	Received observer notification xpcom-will-shutdown
[task 2020-07-08T07:59:24.680Z] 07:59:24     INFO - GECKO(4734) | 1594195164675	Marionette	INFO	Stopped listening on port 2828
[task 2020-07-08T07:59:24.680Z] 07:59:24     INFO - GECKO(4734) | 1594195164676	Marionette	DEBUG	Marionette stopped listening
[task 2020-07-08T07:59:24.897Z] 07:59:24     INFO - GECKO(4734) | -----------------------------------------------------
[task 2020-07-08T07:59:24.897Z] 07:59:24     INFO - GECKO(4734) | Suppressions used:
[task 2020-07-08T07:59:24.897Z] 07:59:24     INFO - GECKO(4734) |   count      bytes template
[task 2020-07-08T07:59:24.897Z] 07:59:24     INFO - GECKO(4734) |      18        568 nsComponentManagerImpl
[task 2020-07-08T07:59:24.897Z] 07:59:24     INFO - GECKO(4734) |       2        288 libfontconfig.so
[task 2020-07-08T07:59:24.898Z] 07:59:24     INFO - GECKO(4734) | -----------------------------------------------------
[task 2020-07-08T07:59:24.936Z] 07:59:24     INFO - GECKO(4734) | -----------------------------------------------------
[task 2020-07-08T07:59:24.936Z] 07:59:24     INFO - GECKO(4734) | Suppressions used:
[task 2020-07-08T07:59:24.939Z] 07:59:24     INFO - GECKO(4734) |   count      bytes template
[task 2020-07-08T07:59:24.939Z] 07:59:24     INFO - GECKO(4734) |      18        568 nsComponentManagerImpl
[task 2020-07-08T07:59:24.940Z] 07:59:24     INFO - GECKO(4734) |     633      18287 libfontconfig.so
[task 2020-07-08T07:59:24.941Z] 07:59:24     INFO - GECKO(4734) | -----------------------------------------------------
[task 2020-07-08T07:59:25.311Z] 07:59:25     INFO - GECKO(4734) | -----------------------------------------------------
[task 2020-07-08T07:59:25.311Z] 07:59:25     INFO - GECKO(4734) | Suppressions used:
[task 2020-07-08T07:59:25.312Z] 07:59:25     INFO - GECKO(4734) |   count      bytes template
[task 2020-07-08T07:59:25.312Z] 07:59:25     INFO - GECKO(4734) |       1         32 nsComponentManagerImpl
[task 2020-07-08T07:59:25.312Z] 07:59:25     INFO - GECKO(4734) | -----------------------------------------------------
[task 2020-07-08T08:02:28.466Z] 08:02:28     INFO - GECKO(4734) | AddressSanitizer:DEADLYSIGNAL
[task 2020-07-08T08:02:28.467Z] 08:02:28     INFO - GECKO(4734) | =================================================================
[task 2020-07-08T08:02:28.467Z] 08:02:28    ERROR - GECKO(4734) | ==4734==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000001 (pc 0x7fd254a50e3f bp 0x7fd18165fe10 sp 0x7fd18165fd60 T96)
[task 2020-07-08T08:02:28.467Z] 08:02:28     INFO - GECKO(4734) | ==4734==The signal is caused by a WRITE memory access.
[task 2020-07-08T08:02:28.467Z] 08:02:28     INFO - GECKO(4734) | ==4734==Hint: address points to the zero page.
[task 2020-07-08T08:02:28.909Z] 08:02:28     INFO - GECKO(4734) |     #0 0x7fd254a50e3e in mozilla::(anonymous namespace)::RunWatchdog(void*) /builds/worker/checkouts/gecko/toolkit/components/terminator/nsTerminator.cpp:217:5
[task 2020-07-08T08:02:28.910Z] 08:02:28     INFO - GECKO(4734) |     #1 0x7fd2675d8d3e in _pt_root /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:201:5
[task 2020-07-08T08:02:28.911Z] 08:02:28     INFO - GECKO(4734) |     #2 0x7fd26b4346da in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76da)
[task 2020-07-08T08:02:28.986Z] 08:02:28     INFO - GECKO(4734) |     #3 0x7fd26a412a3e in clone /build/glibc-2ORdQG/glibc-2.27/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95
[task 2020-07-08T08:02:28.987Z] 08:02:28     INFO - GECKO(4734) | AddressSanitizer can not provide additional info.
[task 2020-07-08T08:02:28.987Z] 08:02:28     INFO - GECKO(4734) | SUMMARY: AddressSanitizer: SEGV /builds/worker/checkouts/gecko/toolkit/components/terminator/nsTerminator.cpp:217:5 in mozilla::(anonymous namespace)::RunWatchdog(void*)
[task 2020-07-08T08:02:28.987Z] 08:02:28     INFO - GECKO(4734) | Thread T96 (Shutdow~minator) created by T0 (MainThread) here:
[task 2020-07-08T08:02:28.990Z] 08:02:28     INFO - GECKO(4734) |     #0 0x559133261b2a in pthread_create /builds/worker/fetches/llvm-project/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cc:209:3
[task 2020-07-08T08:02:28.991Z] 08:02:28     INFO - GECKO(4734) |     #1 0x7fd2675c9195 in _PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:458:14
[task 2020-07-08T08:02:28.992Z] 08:02:28     INFO - GECKO(4734) |     #2 0x7fd2675ba05e in PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:533:12
[task 2020-07-08T08:02:28.992Z] 08:02:28     INFO - GECKO(4734) |     #3 0x7fd254a50b4e in CreateSystemThread /builds/worker/checkouts/gecko/toolkit/components/terminator/nsTerminator.cpp:101:7
[task 2020-07-08T08:02:28.992Z] 08:02:28     INFO - GECKO(4734) |     #4 0x7fd254a50b4e in mozilla::nsTerminator::StartWatchdog() /builds/worker/checkouts/gecko/toolkit/components/terminator/nsTerminator.cpp:426:7
[task 2020-07-08T08:02:28.992Z] 08:02:28     INFO - GECKO(4734) |     #5 0x7fd254a510e4 in Start /builds/worker/checkouts/gecko/toolkit/components/terminator/nsTerminator.cpp:367:3
[task 2020-07-08T08:02:28.993Z] 08:02:28     INFO - GECKO(4734) |     #6 0x7fd254a510e4 in mozilla::nsTerminator::Observe(nsISupports*, char const*, char16_t const*) /builds/worker/checkouts/gecko/toolkit/components/terminator/nsTerminator.cpp:477:5
[task 2020-07-08T08:02:29.001Z] 08:02:29     INFO - GECKO(4734) |     #7 0x7fd249f35843 in nsObserverList::NotifyObservers(nsISupports*, char const*, char16_t const*) /builds/worker/checkouts/gecko/xpcom/ds/nsObserverList.cpp:65:19
[task 2020-07-08T08:02:29.001Z] 08:02:29     INFO - GECKO(4734) |     #8 0x7fd249f3cb72 in nsObserverService::NotifyObservers(nsISupports*, char const*, char16_t const*) /builds/worker/checkouts/gecko/xpcom/ds/nsObserverService.cpp:287:19
[task 2020-07-08T08:02:29.001Z] 08:02:29     INFO - GECKO(4734) |     #9 0x7fd2548942d1 in nsAppStartup::Quit(unsigned int, bool*) /builds/worker/checkouts/gecko/toolkit/components/startup/nsAppStartup.cpp:445:19
[task 2020-07-08T08:02:29.001Z] 08:02:29     INFO - GECKO(4734) |     #10 0x7fd24a0c7dc1 in NS_InvokeByIndex /builds/worker/checkouts/gecko/xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_x86_64_unix.S:106
[task 2020-07-08T08:02:29.017Z] 08:02:29     INFO - GECKO(4734) |     #11 0x7fd24baa47c6 in Invoke /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1618:10
[task 2020-07-08T08:02:29.017Z] 08:02:29     INFO - GECKO(4734) |     #12 0x7fd24baa47c6 in Call /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1174:19
[task 2020-07-08T08:02:29.018Z] 08:02:29     INFO - GECKO(4734) |     #13 0x7fd24baa47c6 in XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1140:23
[task 2020-07-08T08:02:29.018Z] 08:02:29     INFO - GECKO(4734) |     #14 0x7fd24baa9702 in XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNativeJSOps.cpp:946:10
[task 2020-07-08T08:02:29.034Z] 08:02:29     INFO - GECKO(4734) |     #15 0x7fd254cd5837 in CallJSNative /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:484:13
[task 2020-07-08T08:02:29.035Z] 08:02:29     INFO - GECKO(4734) |     #16 0x7fd254cd5837 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:576:12
[task 2020-07-08T08:02:29.035Z] 08:02:29     INFO - GECKO(4734) |     #17 0x7fd254cd7928 in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:639:10
[task 2020-07-08T08:02:29.036Z] 08:02:29     INFO - GECKO(4734) |     #18 0x7fd254cbf08b in CallFromStack /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:643:10
[task 2020-07-08T08:02:29.036Z] 08:02:29     INFO - GECKO(4734) |     #19 0x7fd254cbf08b in Interpret(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:3332:16
[task 2020-07-08T08:02:29.037Z] 08:02:29     INFO - GECKO(4734) |     #20 0x7fd254ca3fa6 in js::RunScript(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:456:10
[task 2020-07-08T08:02:29.037Z] 08:02:29     INFO - GECKO(4734) |     #21 0x7fd254cd591a in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:611:13
[task 2020-07-08T08:02:29.038Z] 08:02:29     INFO - GECKO(4734) |     #22 0x7fd254cd7928 in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:639:10
[task 2020-07-08T08:02:29.038Z] 08:02:29     INFO - GECKO(4734) |     #23 0x7fd254cd7ba9 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:656:8
[task 2020-07-08T08:02:29.054Z] 08:02:29     INFO - GECKO(4734) |     #24 0x7fd254e5cc70 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/jsapi.cpp:2846:10
[task 2020-07-08T08:02:29.090Z] 08:02:29     INFO - GECKO(4734) |     #25 0x7fd24d9dcfb8 in mozilla::dom::MessageListener::ReceiveMessage(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::dom::ReceiveMessageArgument const&, JS::MutableHandle<JS::Value>, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/MessageManagerBinding.cpp:6471:8
[task 2020-07-08T08:02:29.090Z] 08:02:29     INFO - GECKO(4734) |     #26 0x7fd250af2e35 in mozilla::dom::MessageListener::ReceiveMessage(mozilla::dom::ReceiveMessageArgument const&, JS::MutableHandle<JS::Value>, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/MessageManagerBinding.h:784:12
[task 2020-07-08T08:02:29.090Z] 08:02:29     INFO - GECKO(4734) |     #27 0x7fd250af263c in mozilla::dom::JSActor::ReceiveMessageOrQuery(JSContext*, mozilla::dom::JSActorMessageMeta const&, JS::Handle<JS::Value>, mozilla::ErrorResult&) /builds/worker/checkouts/gecko/dom/ipc/JSActor.cpp:353:20
[task 2020-07-08T08:02:29.090Z] 08:02:29     INFO - GECKO(4734) |     #28 0x7fd250af14b3 in mozilla::dom::JSActor::ReceiveRawMessage(mozilla::dom::JSActorMessageMeta const&, mozilla::dom::ipc::StructuredCloneData&&, mozilla::dom::ipc::StructuredCloneData&&) /builds/worker/checkouts/gecko/dom/ipc/JSActor.cpp:310:7
[task 2020-07-08T08:02:29.106Z] 08:02:29     INFO - GECKO(4734) |     #29 0x7fd250b4f738 in mozilla::dom::WindowGlobalParent::ReceiveRawMessage(mozilla::dom::JSActorMessageMeta const&, mozilla::dom::ipc::StructuredCloneData&&, mozilla::dom::ipc::StructuredCloneData&&) /builds/worker/checkouts/gecko/dom/ipc/WindowGlobalParent.cpp:441:12
[task 2020-07-08T08:02:29.107Z] 08:02:29     INFO - GECKO(4734) |     #30 0x7fd250b4f54b in mozilla::dom::WindowGlobalParent::RecvRawMessage(mozilla::dom::JSActorMessageMeta const&, mozilla::dom::ClonedMessageData const&, mozilla::dom::ClonedMessageData const&) /builds/worker/checkouts/gecko/dom/ipc/WindowGlobalParent.cpp:431:3
[task 2020-07-08T08:02:29.109Z] 08:02:29     INFO - GECKO(4734) |     #31 0x7fd24b7ed226 in mozilla::dom::PWindowGlobalParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PWindowGlobalParent.cpp:628:62
[task 2020-07-08T08:02:29.145Z] 08:02:29     INFO - GECKO(4734) |     #32 0x7fd24b375451 in mozilla::dom::PContentParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PContentParent.cpp:6578:32
[task 2020-07-08T08:02:29.149Z] 08:02:29     INFO - GECKO(4734) |     #33 0x7fd24b190b3b in mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:2150:25
[task 2020-07-08T08:02:29.149Z] 08:02:29     INFO - GECKO(4734) |     #34 0x7fd24b18da5b in mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:2074:9
[task 2020-07-08T08:02:29.150Z] 08:02:29     INFO - GECKO(4734) |     #35 0x7fd24b18ef25 in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1922:3
[task 2020-07-08T08:02:29.152Z] 08:02:29     INFO - GECKO(4734) |     #36 0x7fd24b18f68e in mozilla::ipc::MessageChannel::MessageTask::Run() /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1953:13
[task 2020-07-08T08:02:29.160Z] 08:02:29     INFO - GECKO(4734) |     #37 0x7fd24a050519 in mozilla::RunnableTask::Run() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:209:16
[task 2020-07-08T08:02:29.160Z] 08:02:29     INFO - GECKO(4734) |     #38 0x7fd24a04ca68 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:459:24
[task 2020-07-08T08:02:29.160Z] 08:02:29     INFO - GECKO(4734) |     #39 0x7fd24a04ad98 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:337:20
[task 2020-07-08T08:02:29.160Z] 08:02:29     INFO - GECKO(4734) |     #40 0x7fd24a04b1a3 in mozilla::TaskController::ProcessPendingMTTask() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:152:3
[task 2020-07-08T08:02:29.160Z] 08:02:29     INFO - GECKO(4734) |     #41 0x7fd24a05c24f in operator() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:82:37
[task 2020-07-08T08:02:29.160Z] 08:02:29     INFO - GECKO(4734) |     #42 0x7fd24a05c24f in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_4>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:577:5
[task 2020-07-08T08:02:29.176Z] 08:02:29     INFO - GECKO(4734) |     #43 0x7fd24a080369 in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1234:14
[task 2020-07-08T08:02:29.177Z] 08:02:29     INFO - GECKO(4734) |     #44 0x7fd24a08aacc in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:513:10
[task 2020-07-08T08:02:29.178Z] 08:02:29     INFO - GECKO(4734) |     #45 0x7fd24b197d1a in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:87:21
[task 2020-07-08T08:02:29.179Z] 08:02:29     INFO - GECKO(4734) |     #46 0x7fd24b0b6097 in RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:334:10
[task 2020-07-08T08:02:29.180Z] 08:02:29     INFO - GECKO(4734) |     #47 0x7fd24b0b6097 in RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:327:3
[task 2020-07-08T08:02:29.186Z] 08:02:29     INFO - GECKO(4734) |     #48 0x7fd24b0b6097 in MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:309:3
[task 2020-07-08T08:02:29.188Z] 08:02:29     INFO - GECKO(4734) |     #49 0x7fd2512d9948 in nsBaseAppShell::Run() /builds/worker/checkouts/gecko/widget/nsBaseAppShell.cpp:137:27
[task 2020-07-08T08:02:29.188Z] 08:02:29     INFO - GECKO(4734) |     #50 0x7fd2548933e2 in nsAppStartup::Run() /builds/worker/checkouts/gecko/toolkit/components/startup/nsAppStartup.cpp:270:30
[task 2020-07-08T08:02:29.189Z] 08:02:29     INFO - GECKO(4734) |     #51 0x7fd254a9d9aa in XREMain::XRE_mainRun() /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:4720:22
[task 2020-07-08T08:02:29.190Z] 08:02:29     INFO - GECKO(4734) |     #52 0x7fd254a9f771 in XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:4869:8
[task 2020-07-08T08:02:29.190Z] 08:02:29     INFO - GECKO(4734) |     #53 0x7fd254aa04c3 in XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:4923:21
[task 2020-07-08T08:02:29.190Z] 08:02:29     INFO - GECKO(4734) |     #54 0x5591332aa50b in do_main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:217:22
[task 2020-07-08T08:02:29.190Z] 08:02:29     INFO - GECKO(4734) |     #55 0x5591332aa50b in main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:331:16
[task 2020-07-08T08:02:29.191Z] 08:02:29     INFO - GECKO(4734) |     #56 0x7fd26a312b96 in __libc_start_main /build/glibc-2ORdQG/glibc-2.27/csu/../csu/libc-start.c:310
[task 2020-07-08T08:02:29.191Z] 08:02:29     INFO - GECKO(4734) | ==4734==ABORTING
[task 2020-07-08T08:08:39.204Z] 08:08:39     INFO - Buffered messages finished
[task 2020-07-08T08:08:39.205Z] 08:08:39    ERROR - TEST-UNEXPECTED-TIMEOUT | Last test finished | application timed out after 370 seconds with no output
Flags: needinfo?(jyavenard)

(In reply to Bogdan Tara[:bogdan_tara | bogdant] from comment #7)

Also seeing the following failures starting with the backed out changes:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308945246&repo=autoland&lineNumber=28993
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308949304&repo=autoland&lineNumber=5793
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308945941&repo=autoland&lineNumber=4019

Sorry I'm confused.

Are you saying you're getting new errors after those changes have been backed-out?

how could that be related to those changes then?

Flags: needinfo?(jyavenard) → needinfo?(btara)

Failures starting with the backed out change set... might not be the best wording, but this is the first complain.

Those failures seem to start on the push with your changes (the initial push), not on the backout push.

If i'm right about those failures, they won't pop up on the backout push, nor on later pushes.

Since i saw those later, after I've backed out and added the backout comment here, i posted a new comment with other failures caused by your changes.

Flags: needinfo?(btara)
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87ef0b1e4dbb
P1. Let CubebDeviceEnumerator worry about MTA requirements. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/4d6f70c037b3
P2. Ensure the CubebDeviceEnumerator is shutdown after the MTAThread. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/4af433832f07
P3. Use a media taskqueue with the MediaManager. r=jib
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: