1650306 - Enable the "no-else-return" rule in pylint and fix the existing issues

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

This can be done by adding the option here:
https://searchfox.org/mozilla-central/source/tools/lint/python/pylint.py#109

Then run with

$ ./mach lint -l pylint  --verbose

As the change should be easy, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Manish Giri]

Hello, I have previously submitted a few one-line patches to Mozilla, but that was in C++, and not in the "Lint and Formatting" project. I just wanted to check if I can still submit a patch for this.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Sure :)

Comment 3

[Manish Giri]

Thank You! I'll get on it right away.

Comment 4

[Manish Giri]

Attachment: Bug 1650306 - Enable 'no-else-return' rule in pylint. r?Sylvestre

Comment 5

[Manish Giri]

Attachment: Bug 1650306 - mozlint/pylint - Enable 'no-else-return' rule r?Sylvestre

Comment 6

[Manish Giri]

Attachment: Bug 1650306 - Address the defects found by the pylint/no-else-return rule. r?Sylvestre

Depends on D82507

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff64dd0c6510
mozlint/pylint - Enable 'no-else-return' rule r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/4a5fa0f58c63
Address the defects found by the pylint/no-else-return rule. r=sylvestre

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ff64dd0c6510
https://hg.mozilla.org/mozilla-central/rev/4a5fa0f58c63