Add a base class with runTaskLocked method
Categories
(Core :: JavaScript Engine, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: allstars.chh, Assigned: allstars.chh)
Details
Attachments
(1 file)
In Bug 1649887 I added runTaskLocked methods in some tasks, we could make it a base class.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
Jonco, can you clarify if those tasks don't need to inherit RunnableTask per your comment
https://phabricator.services.mozilla.com/D82322#2522795
then what's your plan to execute those tasks when we dispatch them to XPCOM thread pool?
https://searchfox.org/mozilla-central/rev/91d82d7cbf05a71954dfa49d0e43824c7c973e62/js/xpconnect/src/XPCJSThreadPool.h#33
|
||
Comment 3•4 years ago
|
||
(In reply to Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh] from comment #2)
We can't get the XPCOM thread pool to execute these tasks directly by calling their runTask() method because we need to do some work after each task (e.g. dispatch the next task). We'll need to have a separate object to do this (which would inherit RunnableTask).
Pushed by allstars.chh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c4ee6735f5a8 Add a base class HelperThreadTask. r=jonco
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Description
•