Port bug 1649740: fix blocklist string for graphics features in about:support
Categories
(Thunderbird :: General, task)
Tracking
(thunderbird_esr78 unaffected, thunderbird79 unaffected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
| thunderbird79 | --- | unaffected |
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file)
|
1.82 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Bug 1649740 changed some strings. We need to follow.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9161374 [details] [diff] [review] 1650532-aboutSupport.patch Review of attachment 9161374 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! r=mkmelin
|
|
||
Updated•4 years ago
|
|
||
Comment 3•4 years ago
|
||
I landed this but there appears to be a CI issue.
https://hg.mozilla.org/comm-central/rev/5aab299c06a5b2592d32c9006417c7aaa8dbb49a
|
||
Comment 4•4 years ago
|
||
Sorry, I didn't realize this would have affected Thunderbird.
For my edification... have you forked about:support ?
How could we make it un-forkable, ie could we somehow allow you to dependency-inject stuff in there so you don't have to maintain the fork and update every time we alter markup/strings for "shared" bits?
|
|
Assignee | |
Comment 5•4 years ago
|
||
Yes, it's a port. We don't use the "Refresh Nightly..." and "Copy raw data to clipboard" but added a " Send via email" and a "Include account names" checkbox. And we added a table for the accounts.
We documented the changes in our aboutSupport.xhtml with comments like <!-- Added for TB --> ... <!-- End of TB addition --> or <!-- Not used on TB.
Maybe you have a proposal how we could inject our code?
|
|
||
Comment 6•4 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #5)
Yes, it's a port. We don't use the "Refresh Nightly..." and "Copy raw data to clipboard" but added a " Send via email" and a "Include account names" checkbox. And we added a table for the accounts.
We documented the changes in our aboutSupport.xhtml with comments like<!-- Added for TB --> ... <!-- End of TB addition -->or<!-- Not used on TB.Maybe you have a proposal how we could inject our code?
I think we should probably come up with a mechanism for apps to inject things - there isn't one right now, but it'd also solve the ugly ifndef android bits that desktop is using in the m-c copy. I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1651348 with some ideas.
Description
•