Closed Bug 1650571 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24442 - [FragmentItem] Clear inline fragment for positioned objects

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24442 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24442
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[FragmentItem] Clear inline fragment for positioned objects

This is a refix of r784685 \<crrev.com/c/2275820>.

When floating objects become positioned, |NGFragmentItems|
can no longer track further changes or destructions. r784685
\<crrev.com/c/1101277> fixed this in pre-layout, but it is
possible that changes can occur before next layout cycle.

This patch marks |NGFragmentItem| as moved and clears the
index in |LayoutBox::StyleWillChange| instead.

Logically speaking, this could happen to non-floating objects
such as inline-block. Our current code reattaches when non-
floating objects become positioned, so only floating objects
can cause this after r784297 \<crrev.com/c/2275373>.

Bug: 1101986, 1101277
Change-Id: I56e53aaf4e0b6b5b0ef78c3f75eaf3ffd3568596

Reviewed-on: https://chromium-review.googlesource.com/2279425
WPT-Export-Revision: 8a0ae7ec1e811886f81174259a997ddde55e5320

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64ce82815389
[wpt PR 24442] - [FragmentItem] Clear inline fragment for positioned objects, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.